Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stub Executable fails when passing 4-level version string #131

Open
mcoomans opened this issue Jun 17, 2021 · 5 comments · May be fixed by #190
Open

Stub Executable fails when passing 4-level version string #131

mcoomans opened this issue Jun 17, 2021 · 5 comments · May be fixed by #190

Comments

@mcoomans
Copy link

mcoomans commented Jun 17, 2021

The stub executable fails to launch the actual app executable when I pass a 4-level windows compatible version string to the MSICreator options (e.g. "2.2.0.4") . It works when I pass a 3-level version string (e.g. "2.2.0").

@linonetwo
Copy link

How do you get that stub executable work? My short cut in the desktop seems point to the installer.

@inthegarage
Copy link

inthegarage commented Apr 3, 2023

I have seen the same problem: The overall error is as follows:

Faulting application name: my-app.exe, version: 4.0.0.0, time stamp: 0x5f64eb21
Faulting module name: my-app.exe, version: 4.0.0.0, time stamp: 0x5f64eb21
Exception code: 0xc0000409
Fault offset: 0x0000e841
Faulting process id: 0x4960
Faulting application start time: 0x01d966493c1c594f
Faulting application path: C:\Program Files\myapp\my-app.exe
Faulting module path: C:\Program Files\my-app\my-app.exe
Report Id: f26180e9-1aa2-42fa-8e51-bdff783a0e62
Faulting package full name: 
Faulting package-relative application ID: 

It's weird as the actual specified version is 4.0.0.7, but this seems to be referring to 4.0.0.0. In my configuration there is no mention of 4.0.0.0 at all.
My guess is that it's truncating a version somewhere and later on it can't find "the version". Reverting to a 3 stage version number cures the issue.

@Sebazzz
Copy link

Sebazzz commented Aug 16, 2024

Still not fixed unfortunately. If you manually rename the subdirectory to have three version component, the real executable is properly launched. I'm not sure how to skip generating that stub exe at all. I don't see the added value, since a MSI cannot be installed side-by-side.

@lockiechen
Copy link

there is plan to fix it?
@Sebazzz

@ShGKme
Copy link

ShGKme commented Feb 14, 2025

StubExecutable expects app's version to be a valid semantic version, while the 4-level version is not a valid semantic version.

So this is an expected behavior. In the base case, electron-wix-msi may check the version to be valid and show an explicit error.

If you are using it via @electron-forge/maker-wix - this is probably the source of the issue. The MakerWix replaces a valid semantic version with windows compatible, making it an invalid semantic version.

@ShGKme ShGKme linked a pull request Feb 19, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants