fix: check for semantic version #190
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StubExecutable expects app's version to be a valid semantic version
However,
electron-wix-msisuccessfully creates a package with an invalid semantic version, e.g., Windows version1.2.3.4. The created packages then cannot be launched from the created shortcut or Stub Executable.This PR adds a check for
versionto be a valid semantic version and to prevent successful creation of an invalid package.To make the change less destructive, it tries to transform a Windows version into a semantic one in the most probable case:
1.2.3.4 -> 1.2.3+4