Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: define NOMINMAX in common.gypi #45872

Merged
merged 1 commit into from
Mar 3, 2025
Merged

build: define NOMINMAX in common.gypi #45872

merged 1 commit into from
Mar 3, 2025

Conversation

codebytere
Copy link
Member

Description of Change

Closes #45826.
Refs nodejs/node#52794.

Fixes an issue where native Node.js addons including uv.h before node.h don't compile as expected.

Checklist

Release Notes

Notes: Fixed an issue where native Node.js addons including uv.h before node.h don't compile as expected.

@codebytere codebytere added backport This is a backport PR semver/patch backwards-compatible bug fixes backport-check-skip Skip trop's backport validity checking 33-x-y labels Mar 3, 2025
@codebytere codebytere requested a review from a team as a code owner March 3, 2025 11:10
@jkleinsc jkleinsc merged commit f49816e into 33-x-y Mar 3, 2025
62 checks passed
@jkleinsc jkleinsc deleted the nominmax-33 branch March 3, 2025 14:34
@release-clerk
Copy link

release-clerk bot commented Mar 3, 2025

Release Notes Persisted

Fixed an issue where native Node.js addons including uv.h before node.h don't compile as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkleinsc jkleinsc jkleinsc approved these changes

Assignees
No one assigned
Labels
33-x-y backport This is a backport PR backport-check-skip Skip trop's backport validity checking semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@codebytere @jkleinsc