test: fix up backport tests #337
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsanders11
force-pushed
the
test/fix-backport-tests
branch
from
7baab71 to
3ed24fe
Compare
codebytere
approved these changes
May 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test fixtures for backport PRs were not quite right as they didn't have their
base.refset to a non-mainbranch. Updates the fixtures to be accurate and then some minor tweaks to the tests to get them working again. Also added a missingpull_request.numberfield on some of the fixtures - note that in the webhook event payloadnumberis indeed both a top-level field and duplicated insidepull_request.Marks the tests I added in #336 as skipped because I whiffed the implementation in that PR but didn't notice at the time because the tests passed due to the incorrect test fixtures. Fixing them cause the tests to fail, so I'm going to skip them for now and they'll be fixed in a follow-up PR that fixes the feat added in #336.