Use responsive friendly grid layout #37
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that on mobile the content horizontally overflows off both sized the screen in a way that makes it impossible to read the content on the left edge. This is a symptom of using inline centring inside of a grid that has no track sizes — a footgun of CSS grid.
This PR uses a grid with three columns:
2rem(--size-7), but then equally expand to fill the rest of the available space, effectively centring the content.content, is for the content. Both the<main>and<footer>elements are assigned to this column. It has a track size with a maximum of 80 characters which I took from the paragraph styles (--size-content-3). When 80 characters is greater than 100% of the grid’s inline size minus the gutters, it’ll use that value instead.I also removed the UA
marginon the body and adjusted the minimum inline size of the code snippets to avoid overflow.Before
After