Better feedback on failure cases during login #4198
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This includes: - displaying the list of upstream providers on failed password logins - showing a proper 'account deactivated' or 'account locked' page - show the generic error page on 500-like errors
sandhose
added
A-Login-Flow
Deploying matrix-authentication-service-docs with
|
| Latest commit: |
4510ab4
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://8f44ef4d.matrix-authentication-service-docs.pages.dev |
| Branch Preview URL: | https://quenting-better-login-feedba.matrix-authentication-service-docs.pages.dev |
reivilibre
approved these changes
Mar 12, 2025
|
|
||
| // At this point, we should have a 'valid' user. In case we missed something, we | ||
| // want it to crash in tests/debug builds | ||
| debug_assert!(user.is_valid()); |
There was a problem hiding this comment.
tbh, I'd be in favour of making this a full-blown assert.
I'd only use debug_assert for perf reasons, which doesn't seem to apply here.
There was a problem hiding this comment.
I get that, but I also kinda want tasks to not panic as much as possible? Alternative is to bubble up a proper Error but 🤷
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes:
Fixes #3728