Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: display cover image for article #1044

Closed
wants to merge 1 commit into from
Closed

feat: display cover image for article #1044

wants to merge 1 commit into from

Conversation

fpasquet
Copy link
Contributor

No description provided.

@fpasquet fpasquet self-assigned this Nov 28, 2023
@fpasquet fpasquet requested review from Pouzor and ch3ric November 28, 2023 14:34
@fpasquet fpasquet added status/mergeable status: mergeable status/reviewable status: reviewable labels Nov 28, 2023
@fpasquet fpasquet mentioned this pull request Nov 28, 2023
Closed
@github-actions github-actions bot temporarily deployed to dev-feat/cover-image November 28, 2023 14:41 Destroyed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 28, 2023 •
edited
Loading

⚡️🏠 Lighthouse report

Here's the summary:

Path Performance Accessibility Best practices SEO PWA
/feat/cover-image/ 🟠 65 🟢 100 🟢 92 🟢 92 🟠 70
/feat/cover-image/fr/authors/ajacquemin/ 🟠 69 🟢 97 🟠 83 🟢 92 🟠 70
/feat/cover-image/fr/comment-construire-site-web-avec-nextjs/ 🟠 77 🟢 98 🟠 83 🟢 100 🟠 70
/feat/cover-image/fr/nestjs-le-cycle-de-vie-dune-requete/ 🟠 73 🟢 98 🟠 83 🟢 97 🟠 70

Here's the audits:

Path FCP
1800 <=		 LCP
2500 <=		 Speed Index
3400 <=		 TTI
3800 <=		 TBT
200 <=		 CLS
0.1 <=
/feat/cover-image/ 🔴 2602 🔴 8810 🟢 2602 🔴 8697 🟢 13 🟢 0
/feat/cover-image/fr/authors/ajacquemin/ 🟢 1691 🔴 8023 🟢 2103 🔴 7809 🟢 12 🟢 0
/feat/cover-image/fr/comment-construire-site-web-avec-nextjs/ 🔴 2613 🔴 3801 🟢 2628 🔴 10099 🟢 10 🟢 0
/feat/cover-image/fr/nestjs-le-cycle-de-vie-dune-requete/ 🔴 2153 🔴 4742 🟢 2392 🔴 4523 🟢 6 🟢 0.07

@RedHotMan
Copy link
Contributor

Couldn't test, network calls to get images have 404 response

@github-actions github-actions bot temporarily deployed to dev-feat/cover-image November 28, 2023 15:27 Destroyed
@fpasquet
Copy link
Contributor Author

Check article =>
http://dev.blog.eleven-labs.com.s3-website.eu-west-2.amazonaws.com/feat/cover-image/fr/symfony-et-mongodb-retour-aux-sources/

@fpasquet fpasquet closed this Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RedHotMan RedHotMan RedHotMan approved these changes

@Pouzor Pouzor Awaiting requested review from Pouzor

@ch3ric ch3ric Awaiting requested review from ch3ric

Assignees

@fpasquet fpasquet

Labels
No merge status/mergeable status: mergeable status/reviewable status: reviewable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fpasquet @RedHotMan