Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: validate headings in markdown #1060

Merged
merged 4 commits into from
Feb 1, 2024
Merged

feat: validate headings in markdown #1060

merged 4 commits into from
Feb 1, 2024

Conversation

fpasquet
Copy link
Contributor

No description provided.

@fpasquet fpasquet added status/mergeable status: mergeable status/reviewable status: reviewable labels Jan 25, 2024
@fpasquet fpasquet requested a review from ch3ric January 25, 2024 07:22
@fpasquet fpasquet self-assigned this Jan 25, 2024
@fpasquet fpasquet force-pushed the feat/validate-heading branch 3 times, most recently from c1a8e0a to 2eedc47 Compare January 25, 2024 08:04
@github-actions github-actions bot temporarily deployed to dev-feat/validate-heading January 25, 2024 08:05 Destroyed
@fpasquet fpasquet force-pushed the feat/validate-heading branch from 2eedc47 to 6f72a6b Compare January 25, 2024 08:28
@github-actions github-actions bot temporarily deployed to dev-feat/validate-heading January 25, 2024 08:30 Destroyed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 25, 2024 •
edited
Loading

⚡️🏠 Lighthouse report

Here's the summary:

Path Performance Accessibility Best practices SEO PWA
/feat/validate-heading/ 🟠 71 🟢 100 🟢 92 🟢 92 🟠 70
/feat/validate-heading/fr/authors/ajacquemin/ 🟢 91 🟢 100 🟢 92 🟢 92 🟠 70
/feat/validate-heading/fr/comment-construire-site-web-avec-nextjs/ 🟠 69 🟢 98 🟠 83 🟢 100 🟠 70
/feat/validate-heading/fr/nestjs-le-cycle-de-vie-dune-requete/ 🟠 64 🟢 98 🟠 83 🟢 97 🟠 70

Here's the audits:

Path FCP
1800 <=		 LCP
2500 <=		 Speed Index
3400 <=		 TTI
3800 <=		 TBT
200 <=		 CLS
0.1 <=
/feat/validate-heading/ 🔴 3453 🔴 3453 🔴 3453 🔴 7926 🟢 17 🟢 0
/feat/validate-heading/fr/authors/ajacquemin/ 🔴 2574 🔴 2574 🟢 2574 🔴 4683 🟢 8 🟢 0
/feat/validate-heading/fr/comment-construire-site-web-avec-nextjs/ 🔴 3456 🔴 4510 🔴 3456 🔴 10124 🟢 9 🟢 0
/feat/validate-heading/fr/nestjs-le-cycle-de-vie-dune-requete/ 🔴 3152 🔴 5774 🟢 3152 🔴 6626 🟢 8 🟢 0.09

@fpasquet fpasquet force-pushed the feat/validate-heading branch from 6f72a6b to 145f3ee Compare January 25, 2024 08:56
@github-actions github-actions bot temporarily deployed to dev-feat/validate-heading January 25, 2024 08:57 Destroyed
ch3ric
ch3ric reviewed Jan 25, 2024
View reviewed changes
@fpasquet fpasquet requested a review from ch3ric January 29, 2024 11:39
@github-actions github-actions bot temporarily deployed to dev-feat/validate-heading January 29, 2024 11:40 Destroyed
@github-actions github-actions bot temporarily deployed to dev-feat/validate-heading January 29, 2024 15:23 Destroyed
@fpasquet fpasquet requested review from Cindyvlv and ch3ric January 30, 2024 13:25
@github-actions github-actions bot temporarily deployed to dev-feat/validate-heading January 30, 2024 13:27 Destroyed
@fpasquet fpasquet merged commit 02b9b7d into master Feb 1, 2024
2 checks passed
@fpasquet fpasquet deleted the feat/validate-heading branch February 1, 2024 16:35
@ch3ric
Copy link
Member

ch3ric commented Feb 6, 2024

✔️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cindyvlv Cindyvlv Awaiting requested review from Cindyvlv

@ch3ric ch3ric Awaiting requested review from ch3ric

Assignees

@fpasquet fpasquet

Labels
status/mergeable status: mergeable status/reviewable status: reviewable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fpasquet @ch3ric @Cindyvlv