Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: i18n initialization with island architecture #1090

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

fpasquet
Copy link
Contributor

No description provided.

@fpasquet fpasquet self-assigned this Apr 10, 2024
@fpasquet fpasquet added status/mergeable status: mergeable status/reviewable status: reviewable labels Apr 10, 2024
@fpasquet fpasquet requested a review from loverg-c April 10, 2024 15:20
@fpasquet fpasquet deployed to 1090/merge April 10, 2024 15:21 — with GitHub Actions Active
@github-actions github-actions bot temporarily deployed to fix/i18n-island-architecture April 10, 2024 15:25 Destroyed
Copy link
Contributor

⚡️🏠 Lighthouse report

Here's the summary:

Path Performance Accessibility Best practices SEO PWA
/fix/i18n-island-architecture/ 🟢 92 🟢 90 🟢 100 🟢 100 🟠 70
/fix/i18n-island-architecture/fr/authors/ajacquemin/ 🟢 94 🟢 90 🟢 100 🟢 92 🟠 70
/fix/i18n-island-architecture/fr/comment-construire-site-web-avec-nextjs/ 🟠 79 🟠 80 🟢 100 🟢 100 🟠 70
/fix/i18n-island-architecture/fr/nestjs-le-cycle-de-vie-dune-requete/ 🟢 90 🟠 80 🟢 100 🟢 97 🟠 70

Here's the audits:

Path FCP
1800 <=
LCP
2500 <=
Speed Index
3400 <=
TTI
3800 <=
TBT
200 <=
CLS
0.1 <=
/fix/i18n-island-architecture/ 🔴 2294 🟢 2335 🟢 2600 🔴 4148 🟢 6 🔴 0.12
/fix/i18n-island-architecture/fr/authors/ajacquemin/ 🔴 2306 🟢 2306 🟢 2811 🔴 4056 🟢 6 🟢 0.01
/fix/i18n-island-architecture/fr/comment-construire-site-web-avec-nextjs/ 🔴 2459 🔴 2640 🟢 2459 🔴 4544 🟢 5 🟢 0.03
/fix/i18n-island-architecture/fr/nestjs-le-cycle-de-vie-dune-requete/ 🔴 2054 🟢 2054 🟢 2443 🔴 4525 🟢 6 🟢 0.04

@fpasquet fpasquet merged commit d77c9d0 into master Apr 11, 2024
9 checks passed
@fpasquet fpasquet deleted the fix/i18n-island-architecture branch April 11, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/mergeable status: mergeable status/reviewable status: reviewable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant