Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: regex to detect external urls #1110

Merged
merged 1 commit into from
Apr 16, 2024
Merged

fix: regex to detect external urls #1110

merged 1 commit into from
Apr 16, 2024

Conversation

fpasquet
Copy link
Contributor

No description provided.

@fpasquet fpasquet added status/mergeable status: mergeable status/reviewable status: reviewable labels Apr 15, 2024
@fpasquet fpasquet self-assigned this Apr 15, 2024
@fpasquet fpasquet requested a review from ch3ric April 15, 2024 11:46
@github-actions github-actions bot temporarily deployed to fix/link-nofollow April 15, 2024 11:51 Destroyed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 15, 2024 •
edited
Loading

⚡️🏠 Lighthouse report

Here's the summary:

Path Performance Accessibility Best practices SEO PWA
/fix/link-nofollow/ 🟢 91 🟢 90 🟢 100 🟢 100 🟠 70
/fix/link-nofollow/fr/authors/ajacquemin/ 🟠 71 🟢 90 🟢 100 🟢 92 🟠 70
/fix/link-nofollow/fr/comment-construire-site-web-avec-nextjs/ 🟠 74 🟠 80 🟢 100 🟢 100 🟠 70
/fix/link-nofollow/fr/nestjs-le-cycle-de-vie-dune-requete/ 🟠 71 🟠 80 🟢 100 🟢 97 🟠 70

Here's the audits:

Path FCP
1800 <=		 LCP
2500 <=		 Speed Index
3400 <=		 TTI
3800 <=		 TBT
200 <=		 CLS
0.1 <=
/fix/link-nofollow/ 🔴 2273 🟢 2316 🟢 2343 🔴 4093 🟢 6 🔴 0.12
/fix/link-nofollow/fr/authors/ajacquemin/ 🔴 2234 🔴 2533 🟢 2902 🔴 4048 🟢 7 🟢 0.01
/fix/link-nofollow/fr/comment-construire-site-web-avec-nextjs/ 🔴 2385 🔴 2680 🟢 2424 🔴 4514 🟢 6 🟢 0.03
/fix/link-nofollow/fr/nestjs-le-cycle-de-vie-dune-requete/ 🔴 2001 🟢 2388 🟢 2427 🔴 4623 🟢 6 🟢 0.04

@fpasquet fpasquet requested a review from seinhorn April 15, 2024 11:56
@fpasquet fpasquet force-pushed the fix/link-nofollow branch from 0f05e95 to 084b446 Compare April 16, 2024 06:30
@fpasquet fpasquet deployed to 1110/merge April 16, 2024 06:32 — with GitHub Actions Active
@github-actions github-actions bot temporarily deployed to fix/link-nofollow April 16, 2024 06:35 Destroyed
@fpasquet fpasquet merged commit 8396511 into master Apr 16, 2024
9 checks passed
@fpasquet fpasquet deleted the fix/link-nofollow branch April 16, 2024 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ch3ric ch3ric ch3ric left review comments

@nicolas-grevin nicolas-grevin nicolas-grevin approved these changes

@seinhorn seinhorn Awaiting requested review from seinhorn

Assignees

@fpasquet fpasquet

Labels
status/mergeable status: mergeable status/reviewable status: reviewable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fpasquet @ch3ric @nicolas-grevin