Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[crossplane article] Add tangible exemples + clarify and fix a few things #1128

Merged
merged 5 commits into from
May 22, 2024
Merged

[crossplane article] Add tangible exemples + clarify and fix a few things #1128

merged 5 commits into from
May 22, 2024

Conversation

dimitri-fert
Copy link
Contributor

@dimitri-fert dimitri-fert commented May 20, 2024 •
edited
Loading

  • Rectify wrong statement, .spec.compositeTypeRef is not optional on a Composition
  • Add tangible applied exemples
  • Fix wrong references annotations[] -->metadata.annotations[]
  • Add a few details for clarity

@github-actions github-actions bot temporarily deployed to fix/update_crossplane_french_article May 20, 2024 14:06 Destroyed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 20, 2024 •
edited
Loading

⚡️🏠 Lighthouse report

Here's the summary:

Path Performance Accessibility Best practices SEO PWA
/fix/update_crossplane_french_article/ 🟢 92 🟢 90 🟢 100 🟢 92 🟠 70
/fix/update_crossplane_french_article/fr/authors/ajacquemin/ 🟠 71 🟢 90 🟢 100 🟢 92 🟠 70
/fix/update_crossplane_french_article/fr/comment-construire-site-web-avec-nextjs/ 🟠 74 🟠 80 🟢 100 🟢 100 🟠 70
/fix/update_crossplane_french_article/fr/nestjs-le-cycle-de-vie-dune-requete/ 🟢 95 🟠 80 🟢 100 🟢 97 🟠 70

Here's the audits:

Path FCP
1800 <=		 LCP
2500 <=		 Speed Index
3400 <=		 TTI
3800 <=		 TBT
200 <=		 CLS
0.1 <=
/fix/update_crossplane_french_article/ 🔴 2285 🟢 2340 🟢 2292 🔴 4046 🟢 9 🔴 0.12
/fix/update_crossplane_french_article/fr/authors/ajacquemin/ 🔴 2248 🔴 6799 🟢 2950 🔴 4089 🟢 8 🟢 0
/fix/update_crossplane_french_article/fr/comment-construire-site-web-avec-nextjs/ 🔴 2415 🟢 2415 🟢 2439 🔴 4385 🟢 8 🟢 0.03
/fix/update_crossplane_french_article/fr/nestjs-le-cycle-de-vie-dune-requete/ 🔴 2012 🟢 2012 🟢 2162 🔴 4237 🟢 8 🟢 0.04

@github-actions github-actions bot temporarily deployed to fix/update_crossplane_french_article May 22, 2024 09:30 Destroyed
@dimitri-fert
feat: add missing providerconfig keys to effectivly change URL endpoints
1996828 
It seems that when `endpoint.services` is unspecified, no endpoint is changed
@github-actions github-actions bot temporarily deployed to fix/update_crossplane_french_article May 22, 2024 11:19 Destroyed
@dimitri-fert dimitri-fert force-pushed the fix/update_crossplane_french_article branch from 839780c to e1e011a Compare May 22, 2024 12:14
@dimitri-fert dimitri-fert deployed to 1128/merge May 22, 2024 12:16 — with GitHub Actions Active
@dimitri-fert dimitri-fert changed the title fix: wrong statement ; spec.compositeTypeRef is required on a Composition [crossplane article] Add tangible exemples + clarify and fix a few things May 22, 2024
@github-actions github-actions bot temporarily deployed to fix/update_crossplane_french_article May 22, 2024 12:20 Destroyed
@ElevenTom ElevenTom merged commit 9b4d052 into master May 22, 2024
8 checks passed
@ElevenTom ElevenTom deleted the fix/update_crossplane_french_article branch May 22, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ElevenTom ElevenTom ElevenTom approved these changes

Assignees

@ElevenTom ElevenTom

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dimitri-fert @ElevenTom