Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Tester le code PySpark avec pytest #1132

Merged
merged 16 commits into from
Jul 23, 2024

Conversation

lepiaf
Copy link
Member

@lepiaf lepiaf commented Jun 27, 2024

No description provided.

@github-actions github-actions bot temporarily deployed to feat-test-unitaire-spark-pytest June 27, 2024 08:25 Destroyed
Copy link
Contributor

github-actions bot commented Jun 27, 2024

⚡️🏠 Lighthouse report

Here's the summary:

Path Performance Accessibility Best practices SEO PWA
/feat-test-unitaire-spark-pytest/ 🟢 91 🟢 90 🟢 100 🟢 92 🟠 70
/feat-test-unitaire-spark-pytest/fr/authors/ajacquemin/ 🟠 71 🟢 90 🟢 100 🟢 92 🟠 70
/feat-test-unitaire-spark-pytest/fr/comment-construire-site-web-avec-nextjs/ 🟠 76 🟠 80 🟢 100 🟢 100 🟠 70
/feat-test-unitaire-spark-pytest/fr/nestjs-le-cycle-de-vie-dune-requete/ 🟠 73 🟠 80 🟢 100 🟢 97 🟠 70

Here's the audits:

Path FCP
1800 <=
LCP
2500 <=
Speed Index
3400 <=
TTI
3800 <=
TBT
200 <=
CLS
0.1 <=
/feat-test-unitaire-spark-pytest/ 🔴 2259 🟢 2272 🟢 2259 🔴 4019 🟢 8 🔴 0.12
/feat-test-unitaire-spark-pytest/fr/authors/ajacquemin/ 🔴 2197 🟢 2197 🟢 2252 🔴 4032 🟢 8 🟢 0.01
/feat-test-unitaire-spark-pytest/fr/comment-construire-site-web-avec-nextjs/ 🔴 2380 🟢 2380 🟢 2416 🔴 4113 🟢 8 🟢 0.03
/feat-test-unitaire-spark-pytest/fr/nestjs-le-cycle-de-vie-dune-requete/ 🔴 1978 🟢 1978 🟢 2304 🔴 4118 🟢 8 🟢 0.04

@lepiaf lepiaf changed the title Feat test unitaire spark pytest feat: Tester le code PySpark avec pytest Jul 3, 2024
@lepiaf lepiaf force-pushed the feat-test-unitaire-spark-pytest branch from c68c07f to 6f284f9 Compare July 15, 2024 14:05
@github-actions github-actions bot temporarily deployed to feat-test-unitaire-spark-pytest July 15, 2024 14:10 Destroyed
@github-actions github-actions bot temporarily deployed to feat-test-unitaire-spark-pytest July 15, 2024 14:10 Destroyed
@github-actions github-actions bot temporarily deployed to feat-test-unitaire-spark-pytest July 15, 2024 14:10 Destroyed
@github-actions github-actions bot temporarily deployed to feat-test-unitaire-spark-pytest July 15, 2024 15:10 Destroyed
@lepiaf lepiaf removed the WIP label Jul 15, 2024
@github-actions github-actions bot temporarily deployed to feat-test-unitaire-spark-pytest July 15, 2024 15:45 Destroyed
@lepiaf lepiaf requested a review from ElevenTom July 15, 2024 15:47
Copy link
Contributor

Images automagically compressed by Calibre's image-actions

Compression reduced images by 42.4%, saving 336.65 KB.

Filename Before After Improvement Visual comparison
_assets/articles/2024-07-23-tester-spark-avec-pytest/cover.jpg 793.76 KB 457.11 KB -42.4% View diff

1201 images did not require optimisation.

@github-actions github-actions bot temporarily deployed to feat-test-unitaire-spark-pytest July 15, 2024 15:49 Destroyed
@github-actions github-actions bot temporarily deployed to feat-test-unitaire-spark-pytest July 15, 2024 15:51 Destroyed
Copy link
Contributor

@dimitri-fert dimitri-fert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestions

@github-actions github-actions bot temporarily deployed to feat-test-unitaire-spark-pytest July 15, 2024 17:36 Destroyed
@github-actions github-actions bot temporarily deployed to feat-test-unitaire-spark-pytest July 16, 2024 08:42 Destroyed
@github-actions github-actions bot temporarily deployed to feat-test-unitaire-spark-pytest July 18, 2024 08:01 Destroyed
@lepiaf lepiaf force-pushed the feat-test-unitaire-spark-pytest branch from 381369f to b196fe3 Compare July 23, 2024 09:20
@github-actions github-actions bot temporarily deployed to feat-test-unitaire-spark-pytest July 23, 2024 09:25 Destroyed
@github-actions github-actions bot temporarily deployed to feat-test-unitaire-spark-pytest July 23, 2024 12:57 Destroyed
======================= 1 failed, 1 passed, 2 warnings in 7.80s =======================
```

Tiens, c'est bizarre 🤔, le test est en échec. Pourtant, le résultat attendu est correct.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Tiens, c'est bizarre 🤔, le test est en échec. Pourtant, le résultat attendu est correct.
Tiens, c'est bizarre, le test est en échec. Pourtant, le résultat attendu est correct.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

c'est dommage, j'aime bien cet émoji, ça correspond bien au contexte.

@github-actions github-actions bot temporarily deployed to feat-test-unitaire-spark-pytest July 23, 2024 15:03 Destroyed
@ElevenTom ElevenTom deployed to 1132/merge July 23, 2024 15:48 — with GitHub Actions Active
@github-actions github-actions bot temporarily deployed to feat-test-unitaire-spark-pytest July 23, 2024 15:52 Destroyed
@ElevenTom ElevenTom merged commit 9b08f45 into master Jul 23, 2024
8 checks passed
@ElevenTom ElevenTom deleted the feat-test-unitaire-spark-pytest branch July 23, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants