Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add cover for spark article #1134

Closed
wants to merge 10 commits into from
Closed

Conversation

lepiaf
Copy link
Member

@lepiaf lepiaf commented Jul 15, 2024

No description provided.

Copy link
Contributor

Images automagically compressed by Calibre's image-actions

Compression reduced images by 88.3%, saving 890.86 KB.

Filename Before After Improvement Visual comparison
_assets/articles/2024-07-08-demarrer-apache-spark/cover.webp 1,008.87 KB 118.01 KB -88.3% View diff

1201 images did not require optimisation.

Copy link
Contributor

Images automagically compressed by Calibre's image-actions

Compression reduced images by 3.2%, saving 3.72 KB.

Filename Before After Improvement Visual comparison
_assets/articles/2024-07-08-demarrer-apache-spark/cover.webp 118.01 KB 114.28 KB -3.2% View diff

1201 images did not require optimisation.

Copy link
Contributor

Images automagically compressed by Calibre's image-actions

Compression reduced images by 2.5%, saving 2.91 KB.

Filename Before After Improvement Visual comparison
_assets/articles/2024-07-08-demarrer-apache-spark/cover.webp 114.28 KB 111.38 KB -2.5% View diff

1201 images did not require optimisation.

@github-actions github-actions bot temporarily deployed to fix-cover-article-spark July 15, 2024 10:56 Destroyed
@lepiaf lepiaf changed the title Fix cover article spark fix: add cover for spark article Jul 15, 2024
Copy link
Contributor

github-actions bot commented Jul 15, 2024

⚡️🏠 Lighthouse report

Here's the summary:

Path Performance Accessibility Best practices SEO PWA
/fix-cover-article-spark/ 🟢 91 🟢 90 🟢 100 🟢 92 🟠 70
/fix-cover-article-spark/fr/authors/ajacquemin/ 🟠 71 🟢 90 🟢 100 🟢 92 🟠 70
/fix-cover-article-spark/fr/comment-construire-site-web-avec-nextjs/ 🟠 76 🟠 80 🟢 100 🟢 100 🟠 70
/fix-cover-article-spark/fr/nestjs-le-cycle-de-vie-dune-requete/ 🟠 73 🟠 80 🟢 100 🟢 97 🟠 70

Here's the audits:

Path FCP
1800 <=
LCP
2500 <=
Speed Index
3400 <=
TTI
3800 <=
TBT
200 <=
CLS
0.1 <=
/fix-cover-article-spark/ 🔴 2259 🔴 2559 🟢 2259 🔴 4103 🟢 8 🔴 0.12
/fix-cover-article-spark/fr/authors/ajacquemin/ 🔴 2211 🔴 2513 🟢 2244 🔴 4020 🟢 8 🟢 0.01
/fix-cover-article-spark/fr/comment-construire-site-web-avec-nextjs/ 🔴 2352 🔴 2802 🟢 2415 🔴 4110 🟢 8 🟢 0.03
/fix-cover-article-spark/fr/nestjs-le-cycle-de-vie-dune-requete/ 🔴 1996 🟢 1996 🟢 2277 🔴 4187 🟢 8 🟢 0.04

Copy link
Contributor

@dimitri-fert dimitri-fert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after viewing the result on the feature env

@github-actions github-actions bot temporarily deployed to fix-cover-article-spark July 16, 2024 10:01 Destroyed
@lepiaf lepiaf removed the request for review from ElevenTom July 16, 2024 10:06
@lepiaf lepiaf deployed to 1134/merge July 16, 2024 10:10 — with GitHub Actions Active
Copy link
Contributor

Images automagically compressed by Calibre's image-actions

Compression reduced images by 88.3%, saving 890.86 KB.

Filename Before After Improvement Visual comparison
_assets/articles/2024-07-08-demarrer-apache-spark/cover.webp 1,008.87 KB 118.01 KB -88.3% View diff

1201 images did not require optimisation.

@github-actions github-actions bot temporarily deployed to fix-cover-article-spark July 16, 2024 10:14 Destroyed
@lepiaf lepiaf closed this Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants