Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add cover for spark article #1136

Merged
merged 10 commits into from
Jul 18, 2024
Merged

Conversation

lepiaf
Copy link
Member

@lepiaf lepiaf commented Jul 16, 2024

No description provided.

Copy link
Contributor

Images automagically compressed by Calibre's image-actions

Compression reduced images by 88.3%, saving 890.86 KB.

Filename Before After Improvement Visual comparison
_assets/articles/2024-07-08-demarrer-apache-spark/cover.webp 1,008.87 KB 118.01 KB -88.3% View diff

1201 images did not require optimisation.

@github-actions github-actions bot temporarily deployed to fix-cover-article-spark-bis July 16, 2024 11:27 Destroyed
Copy link
Contributor

github-actions bot commented Jul 16, 2024

⚡️🏠 Lighthouse report

Here's the summary:

Path Performance Accessibility Best practices SEO PWA
/fix-cover-article-spark-bis/ 🟢 90 🟢 90 🟢 100 🟢 92 🟠 70
/fix-cover-article-spark-bis/fr/authors/ajacquemin/ 🟠 71 🟢 90 🟢 100 🟢 92 🟠 70
/fix-cover-article-spark-bis/fr/comment-construire-site-web-avec-nextjs/ 🟠 76 🟠 80 🟢 100 🟢 100 🟠 70
/fix-cover-article-spark-bis/fr/nestjs-le-cycle-de-vie-dune-requete/ 🟠 73 🟠 80 🟢 100 🟢 97 🟠 70

Here's the audits:

Path FCP
1800 <=
LCP
2500 <=
Speed Index
3400 <=
TTI
3800 <=
TBT
200 <=
CLS
0.1 <=
/fix-cover-article-spark-bis/ 🔴 2253 🟢 2465 🟢 2253 🔴 4220 🟢 19 🔴 0.12
/fix-cover-article-spark-bis/fr/authors/ajacquemin/ 🔴 2436 🟢 2436 🟢 2745 🔴 4215 🟢 16 🟢 0.01
/fix-cover-article-spark-bis/fr/comment-construire-site-web-avec-nextjs/ 🔴 2426 🔴 2604 🟢 2426 🔴 4142 🟢 10 🟢 0.03
/fix-cover-article-spark-bis/fr/nestjs-le-cycle-de-vie-dune-requete/ 🔴 1978 🟢 1978 🟢 2407 🔴 4127 🟢 13 🟢 0.04

@github-actions github-actions bot temporarily deployed to fix-cover-article-spark-bis July 16, 2024 11:48 Destroyed
Copy link
Contributor

Images automagically compressed by Calibre's image-actions

Compression reduced images by 3.2%, saving 3.72 KB.

Filename Before After Improvement Visual comparison
_assets/articles/2024-07-08-demarrer-apache-spark/cover.webp 118.01 KB 114.28 KB -3.2% View diff

1201 images did not require optimisation.

Copy link
Contributor

Images automagically compressed by Calibre's image-actions

Compression reduced images by 50%, saving 732.11 KB.

Filename Before After Improvement Visual comparison
_assets/articles/2024-07-08-demarrer-apache-spark/cover.jpg 1.43 MB 732.05 KB -50.0% View diff

1201 images did not require optimisation.

@github-actions github-actions bot temporarily deployed to fix-cover-article-spark-bis July 16, 2024 12:21 Destroyed
@lepiaf lepiaf deployed to 1136/merge July 16, 2024 12:31 — with GitHub Actions Active
@github-actions github-actions bot temporarily deployed to fix-cover-article-spark-bis July 16, 2024 12:35 Destroyed
@ElevenTom ElevenTom merged commit 7b9b999 into master Jul 18, 2024
8 checks passed
@ElevenTom ElevenTom deleted the fix-cover-article-spark-bis branch July 18, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants