Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Automatiser la vérification du commit #1177

Closed
wants to merge 10 commits into from
Closed

Conversation

lepiaf
Copy link
Member

@lepiaf lepiaf commented Nov 13, 2024

No description provided.

@lepiaf lepiaf marked this pull request as ready for review November 13, 2024 12:23
Copy link
Contributor

Images automagically compressed by Calibre's image-actions

Compression reduced images by 42.8%, saving 309.67 KB.

Filename Before After Improvement Visual comparison
_assets/articles/2024-11-26-commit-lint/cover.jpg 723.47 KB 413.80 KB -42.8% View diff

1233 images did not require optimisation.

@github-actions github-actions bot temporarily deployed to feat/commit-lint November 13, 2024 12:28 Destroyed
Copy link
Contributor

github-actions bot commented Nov 13, 2024

⚡️🏠 Lighthouse report

Here's the summary:

Path Performance Accessibility Best practices SEO PWA
/feat/commit-lint/ 🟠 84 🟢 90 🟠 83 🟢 92 🟠 50
/feat/commit-lint/fr/authors/ajacquemin/ 🟠 70 🟢 90 🟠 83 🟢 92 🟠 50
/feat/commit-lint/fr/comment-construire-site-web-avec-nextjs/ 🟠 69 🟠 80 🟠 83 🟢 100 🟠 50
/feat/commit-lint/fr/nestjs-le-cycle-de-vie-dune-requete/ 🟠 67 🟠 80 🟠 83 🟢 97 🟠 50

Here's the audits:

Path FCP
1800 <=
LCP
2500 <=
Speed Index
3400 <=
TTI
3800 <=
TBT
200 <=
CLS
0.1 <=
/feat/commit-lint/ 🔴 2451 🔴 2944 🟢 2897 🔴 4621 🟢 14 🔴 0.12
/feat/commit-lint/fr/authors/ajacquemin/ 🔴 2756 🔴 6514 🟢 2896 🔴 4438 🟢 19 🟢 0.01
/feat/commit-lint/fr/comment-construire-site-web-avec-nextjs/ 🔴 3197 🔴 3465 🟢 3197 🔴 4609 🟢 17 🟢 0.03
/feat/commit-lint/fr/nestjs-le-cycle-de-vie-dune-requete/ 🔴 3053 🔴 3053 🟢 3053 🔴 4595 🟢 15 🟢 0.04

@github-actions github-actions bot temporarily deployed to feat/commit-lint November 13, 2024 12:34 Destroyed
@github-actions github-actions bot temporarily deployed to feat/commit-lint November 13, 2024 12:45 Destroyed
@github-actions github-actions bot temporarily deployed to feat/commit-lint November 13, 2024 12:47 Destroyed
@github-actions github-actions bot temporarily deployed to feat/commit-lint November 13, 2024 13:11 Destroyed
Pour cela, utiliser la variable Gitlab $CI_MERGE_REQUEST_TITLE.
</div>

Félicitation, vous avez automatiser la vérification du message de commit. Prenez une boisson chaude pour vous détendre.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Félicitation, vous avez automatiser la vérification du message de commit. Prenez une boisson chaude pour vous détendre.
Félicitation, vous avez automatisé la vérification du message de commit. Prenez une boisson chaude pour vous détendre.


<div class="admonition note" markdown="1"><p class="admonition-title">Alternatif</p>

Dans le cas d'une merge request, il est possible de vérifier uniquement le titre de la merge request. Ce cas de figure fonctionne bien dans le cas où la branche est fusionné et squash vers la branche principale.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Dans le cas d'une merge request, il est possible de vérifier uniquement le titre de la merge request. Ce cas de figure fonctionne bien dans le cas où la branche est fusionné et squash vers la branche principale.
Dans le cas d'une merge request, il est possible de vérifier uniquement le titre de la merge request. Ce cas de figure fonctionne bien dans le cas où la branche est fusionnée et squash vers la branche principale.


Cette configuration permet d'indiquer à commitlint d'utiliser les commits conventionnels.

Dans le fichier `.gitlab-ci.yml`, ajoutons une tâche pour générer tester le message de commit.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Il faut choisir entre générer et tester :p

@github-actions github-actions bot temporarily deployed to feat/commit-lint November 13, 2024 15:00 Destroyed
@lepiaf lepiaf deployed to 1177/merge November 25, 2024 10:13 — with GitHub Actions Active
@github-actions github-actions bot temporarily deployed to feat/commit-lint November 25, 2024 10:18 Destroyed
@lepiaf lepiaf closed this Nov 26, 2024
@lepiaf lepiaf deleted the feat/commit-lint branch November 26, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants