Logger backend for language server and fixes for debugger #746
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix errors
it will be restarted by the client
stdout and stderr is reserved for debuggee, console and important for debugger
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds logger backend using LSP that translates elixir logger levels to LSP. Thanks to that proper logging metadata is displayed in client. Before that all messages was logged as debug. See spec details here
https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#window_logMessage
Furthermore, I did some cleanup and unification of how we log and show notifications. (relevant spec here
https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#window_showMessage). I especially made sure that we try to show a message before crashing (#741).
I also looked into how we log in debugger and it turned out it was wrong. DAP reserves
stdoutandstderrfor debuggee and debugger should use onlyconsoleandimportant. Up until now we were emitting everything asstdout|err. (see https://microsoft.github.io/debug-adapter-protocol/specification#Events_Output).