fix: reimplement bezier with correct behavior #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ffigiel
commented
Nov 22, 2021
| @@ -73,28 +73,93 @@ linear = | |||
|
|
|||
| {-| A cubic bezier function using 4 parameters: x and y position of first control point, and x and y position of second control point. | |||
|
|
|||
| See [here](http://greweb.me/glsl-transition/example/ "glsl-transitions") for examples or [here](http://cubic-bezier.com/ "tester") to test. | |||
| See [here](http://cubic-bezier.com/ "tester") to test. | |||
There was a problem hiding this comment.
I removed this link since it does not work anymore. Are there other resources we could link to?
| lerp from to v = | ||
| from + (to - from) * v | ||
| f = | ||
| bezierPoint x1 y1 x2 y2 |
There was a problem hiding this comment.
git kinda shredded this diff, it's better to view it side-by-side
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the discussion in #4, this PR fixes the
bezierfunction so that it behaves correctly.The problem was the invalid assumption that the
xcoordinate of the calculated point is equal to thetimeparameter in the equation. The new implementation performs a binary search to find a point whosexcoordinate is closer to thetimeparameter.The original point-calculating function was replaced with a simpler one, and turned out to be much more performant (even after some optimizations).
I came up with a few binary search implementations, but they all perform kinda the same. I also asked @MartinSStewart if he still had his binary search implementation - he had it, but for some reason it was much slower than others, so it was abandoned.
Here are the benchmarks. This PR uses
bezierBinFixedandbezierPointSimpleimplementations.The repo with the benchmarks can be found here.
Should the benchmarks be included in this repo?