Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for AUCTeX and improved configurability #15

Conversation

RomanHargrave
Copy link
Contributor

@RomanHargrave RomanHargrave commented Oct 14, 2024

This PR addresses two issues that I ran into when setting up eglot-ltex:

  1. It was not possible to specify an explicit path to the executable, only an installation root. The ability to do the former is desirable for numerous reasons, including both reduced dependency on the directory structure and file names of another project, and that in certain cases the binary may be installed in a different location or with a different name (e.g. ltex-ls-plus).
  2. When using AUCTeX, eglot would not select the server because it was not marked as supporting LaTeX-mode, which is distinct from latex-mode.

Additionally, I have added some code to detect the server if no explicit file or directory is given, and it is on the path.

@RomanHargrave RomanHargrave changed the title Include AUCTeX in mode list, use function eglot definition form Support for AUCTeX and improved configurability Oct 14, 2024
@jcs090218
Copy link
Member

There are compile warnings:

In eglot-ltex--server-program:
eglot-ltex.el:93:36: Warning: Unused lexical argument `interactive'
eglot-ltex.el:93:48: Warning: Unused lexical argument `project'

Can you resolve these warnings? Thanks! :D

@RomanHargrave
Copy link
Contributor Author

Done

@jcs090218 jcs090218 merged commit 1ec941d into emacs-languagetool:master Oct 14, 2024
13 checks passed
@jcs090218
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants