Skip to content

fix: preserve diagnostics across perspective switches #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

LemonBreezes
Copy link

@LemonBreezes LemonBreezes commented Mar 27, 2025

This patch fixes lsp-treemacs-sync-mode in Doom Emacs. Without this patch, lsp-treemacs-sync-mode completely breaks when persp-mode is enabled.

@LemonBreezes
Copy link
Author

Hello jcs090218. Would you please review this change and #172? #172 can be refactored with mapconcat but is otherwise good. These changes make some pretty important fixes.

@LemonBreezes LemonBreezes force-pushed the fix-persp-switching-errors-list branch from b61628b to 783749e Compare March 28, 2025 16:50
@LemonBreezes
Copy link
Author

Also, let's do #166 as well. Local variables and constants might seem useful to show on the surface but when you actually show them, there are so many it's not useful.

@jcs090218
Copy link
Member

I don't use persp-mode. Can you explain why it breaks persp-mode? 🤔

Thanks!

@LemonBreezes
Copy link
Author

LemonBreezes commented Apr 1, 2025

I don't use persp-mode. Can you explain why it breaks persp-mode? 🤔

Thanks!

What is happening is that when we are switching persps, we are turning off those servers so when we switch back and re-add the folders, they have no connections so the errors list disappears when switching out of and back into a workspace. This is a solution to work around that: remove them but do not shut down the servers.

@LemonBreezes
Copy link
Author

@yyoncho Hello. You are familiar with LSP. Would you please take a look?

@LemonBreezes
Copy link
Author

@jcs090218 Hey, any update on merging this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants