Skip to content

fix(ui-doc): Hide doc frame on next post command #775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jcs090218 merged 1 commit into from
Apr 23, 2024
Merged

fix(ui-doc): Hide doc frame on next post command #775

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions lsp-ui-doc.el
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1247,6 +1247,7 @@ It is supposed to be called from `lsp-ui--toggle'"
(interactive)
(when-let* ((frame (lsp-ui-doc--get-frame))
(visible (lsp-ui-doc--frame-visible-p)))
(remove-hook 'post-command-hook 'lsp-ui-doc--unfocus-frame-post-command)
(remove-hook 'post-command-hook 'lsp-ui-doc--hide-frame)
(set-frame-parameter frame 'lsp-ui-doc--no-focus nil)
(set-frame-parameter frame 'cursor-type t)
Expand All @@ -1263,8 +1264,14 @@ It is supposed to be called from `lsp-ui--toggle'"
(set-frame-parameter frame 'cursor-type nil)
(lsp-ui-doc--with-buffer
(setq cursor-type nil))
(when lsp-ui-doc--from-mouse
(make-frame-invisible frame))))
(if lsp-ui-doc--from-mouse
(make-frame-invisible frame)
(add-hook'post-command-hook 'lsp-ui-doc--unfocus-frame-post-command))))

(defun lsp-ui-doc--unfocus-frame-post-command ()
"Hide frame on the next post command after unfocus frame."
(add-hook 'post-command-hook 'lsp-ui-doc--hide-frame)
(remove-hook 'post-command-hook 'lsp-ui-doc--unfocus-frame-post-command))

(provide 'lsp-ui-doc)
;;; lsp-ui-doc.el ends here