fix(lsp-ui-doc): prevent filling of markdown code blocks#799
Open
tempdragon wants to merge 1 commit intoemacs-lsp:masterfrom
Open
fix(lsp-ui-doc): prevent filling of markdown code blocks#799tempdragon wants to merge 1 commit intoemacs-lsp:masterfrom
tempdragon wants to merge 1 commit intoemacs-lsp:masterfrom
Conversation
- [lsp-ui-doc.el]: refactor `lsp-ui-doc--fill-document` to skip fenced code blocks and add `lsp-ui-doc--fill-check-and-fill` for safer paragraph wrapping. This prevents aggressive reflowing of code signatures while maintaining proper text wrapping for prose.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem Description
The function signatures in Rust, if containing a signature with lengthy parameter names, may fail to show the markdown newlines.
Here is a demonstration:
The result of two different functions as a comparison
Solution
I refactor

lsp-ui-doc--fill-documentto skip fenced code blocks and addlsp-ui-doc--fill-check-and-fillfor safer paragraph wrapping. This prevents aggressive reflowing of code signatures while maintaining proper text wrapping for prose.