Remove cl-flet #225
Merged
Remove cl-flet #225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should not use cl-flet because
- cl-flet is different from flet on Emacs >=24.3
- We should use for defining local function cl-labels or
anonymous function(lambda) + funcall instead of flet
(flet should be used for overriding function temporary,
however we should use cl-letf for this purpose)
- It is unnecessary at all to using cl-flet in php-mode.el now.
|
Thanks, this was educational; I didn't know |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should not use cl-flet because
anonymous function(lambda) + funcall instead of flet
(flet should be used for overriding function temporary,
however we should use cl-letf for this purpose)