Skip to content

Three minor config points #578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 24, 2019
Merged

Three minor config points #578

merged 3 commits into from
Dec 24, 2019

Conversation

sten0
Copy link
Contributor

@sten0 sten0 commented Sep 27, 2019

Please see comments in commit messages, particularly the TODO item in 233715d

@sten0
Update repology paragraph.
e8e00a0 
Move definitions of what this method provides here.

Use `apt` and not `apt-get`, because `apt` has been the recommended
packaging interface since before Debian 9 (stretch), and calling `apt`
on ancient systems will fail--I believe this is what we want, because
a later paragraph says "PLEASE DO NOT INSTALL" ancient versions :-)
@sten0
Modify the second paragraph to show how to track latest dpkg version
8759aac 
I find that "consider the possibility of not incorporating the latest
PHP feature support and performance improvements" is unclear, and I
believe that you wish to express the upstream desire to track recent
versions, so here a solution.  Of course users may always choose to
track MELPA instead!
@sten0
Add "Configuration" section for indentation style.
233715d 
I believe this tip (thanks to mallt) should have greater visibility.
Please note the TODO item.  I'm guessing a post-hook is what you'll
choose to recommend.
@sten0 sten0 marked this pull request as ready for review December 24, 2019 10:03
@sten0
Copy link
Contributor Author

sten0 commented Dec 24, 2019

Thanks for the thumbs up @zonuexe :-) I've marked this ready to review, and am still requesting comment Re: 233715d. The easiest thing to do is just to delete the last sentence and say nothing, but I'd like to check if someone would prefer something else.

@zonuexe
Copy link
Member

zonuexe commented Dec 24, 2019

@sten0 Thanks! LGTM

@zonuexe zonuexe merged commit f1da0be into emacs-php:master Dec 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sten0 @zonuexe