Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce php-base-mode as common base major mode with php-mode #47

Merged
merged 1 commit into from
Dec 5, 2023
Merged

Introduce php-base-mode as common base major mode with php-mode #47

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion php-ts-mode.el
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,9 @@
(require 'cl-lib))
(require 'treesit)
(require 'c-ts-common)
(require 'php nil t)

(declare-function php-base-mode "ext:php")
(declare-function treesit-parser-create "treesit.c")
(declare-function treesit-induce-sparse-tree "treesit.c")
(declare-function treesit-node-child "treesit.c")
Expand Down Expand Up @@ -242,8 +244,17 @@ Return nil if there is no name or if NODE is not a defun node."
(treesit-node-child-by-field-name node "name")
t))))

(unless (eval-when-compile (fboundp 'php-base-mode))
(define-derived-mode php-base-mode prog-mode "PHP base"
"Generic major mode for editing PHP script.

This mode is intended to be inherited by concrete major modes.
Currently there are `php-mode' and `php-ts-mode'."
:group 'php
nil))

;;;###autoload
(define-derived-mode php-ts-mode prog-mode "PHP"
(define-derived-mode php-ts-mode php-base-mode "PHP"
"Major mode for editing PHP files, powered by tree-sitter."
:group 'php
:syntax-table php-ts-mode--syntax-table
Expand Down