rp/pio: fix infinite loop when loading program that wont't fit#5704
Open
trnila wants to merge 1 commit intoembassy-rs:mainfrom
Open
rp/pio: fix infinite loop when loading program that wont't fit#5704trnila wants to merge 1 commit intoembassy-rs:mainfrom
trnila wants to merge 1 commit intoembassy-rs:mainfrom
Conversation
trnila
force-pushed
the
pio_fix_infinite_loop
branch
from
d982b44 to
895193d
Compare
When the returned address wraps around, the search was retried infinitely as the condition `origin < 32` is always satisfied. The loop condition now checks for wrap around. If it occurs, the loop exits since the entire address space has already been searched from zero address.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the returned address wraps around, the search was retried infinitely as the condition
origin < 32is always satisfied.The loop condition now checks for wrap around. If it occurs, the loop exits since the entire address space has already been searched from zero address.
Fixes #5657