Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failures to find most recently added version index object #12

Merged
merged 1 commit into from
Jul 16, 2020
Merged

Fix failures to find most recently added version index object #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion lib/api.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,12 @@ async function processDocs(driver, project) {

await driver.write(
'versions',
[{ id: project, name: project, versions }],
[{
id: project,
name: project,
index_date_timestamp: Date.now(),
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we run into problems if people from different regions ran the script?

Copy link
Member

@ijlee2 ijlee2 Jul 15, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so? It's Heroku Scheduler that runs the script at an interval, so the timezone would be whichever Heroku uses.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think @ijlee2 is correct, the Heroku Scheduler should be the only thing executing this script, but yes if we ran the script locally I suppose we could run into issues.

This approach is meant as a temporary fix until we can better assess how much of the process could be refactored or improved.

FWIW I did confirm via some manual testing that this logic finds the correct index object.

versions
}],
project
)
} catch (err) {
Expand Down
6 changes: 5 additions & 1 deletion lib/drivers/algolia.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,11 @@ async function getPreviouslyIndexedVersions(projectName) {
return []
}

let hit = hits.find(hit => hit.name === projectName)
let hit = hits.filter(hit => (hit.name === projectName) && hit.index_date_timestamp)
.sort(function (a, b) {
return a.index_date_timestamp - b.index_date_timestamp;
})
.pop()

if (!hit) {
return []
Expand Down