Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prettier is failing onapp/templates/index.hbs
because it has a newline at the end of the file. It is odd, because afaict prettier enforces newlines at the end of the file.So far, I have tried editing the.editorconfig
to changeinsert_final_newline = false
under hbs to true. This had no effect (as expected because we are not using and editor to modify the files and because prettier does not respect this configuration).I also tried the route of runningyarn format
after creating theindex.hbs
file. This is a problem because all future patches bring back the newline and also because all future diffs would need to be edited.Update:It appears that prettier does strip newlines in handlebars prettier/prettier#10759 so the question is why did it not do so until now? My only theory is that prettier embedded in eslint avoided this somehow.
I disabled prettier for hbs since we didn't have it previously. When we rewrite for template tag we can take that into account.
We updated the blueprint with proper config for ember-data and released an update.