Add log info in case of no file found by path_prefix #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmikurube
reviewed
Dec 6, 2024
| @@ -23,6 +25,7 @@ public class GcsFileInputPlugin | |||
| .addDefaultModules().build(); | |||
| public static final ConfigMapper CONFIG_MAPPER = CONFIG_MAPPER_FACTORY.createConfigMapper(); | |||
| public static final TaskMapper TASK_MAPPER = CONFIG_MAPPER_FACTORY.createTaskMapper(); | |||
| private static final Logger LOG = LoggerFactory.getLogger(GcsFileInputPlugin.class); | |||
There was a problem hiding this comment.
Can you please use logger instead of LOG?
|
@dmikurube Do we have any other improvement to get the PR approval? Please let us know if you have anything. |
dmikurube
reviewed
Feb 3, 2025
| @@ -23,6 +25,7 @@ public class GcsFileInputPlugin | |||
| .addDefaultModules().build(); | |||
| public static final ConfigMapper CONFIG_MAPPER = CONFIG_MAPPER_FACTORY.createConfigMapper(); | |||
| public static final TaskMapper TASK_MAPPER = CONFIG_MAPPER_FACTORY.createTaskMapper(); | |||
| private Logger logger = LoggerFactory.getLogger(GcsFileInputPlugin.class); | |||
There was a problem hiding this comment.
We usually have the logger instance as a class variable.
Suggested change
| private Logger logger = LoggerFactory.getLogger(GcsFileInputPlugin.class); | |
| private static final Logger logger = LoggerFactory.getLogger(GcsFileInputPlugin.class); |
| @@ -62,6 +65,9 @@ else if (AuthUtils.AuthMethod.private_key.equals(task.getAuthMethod())) { | |||
| // list files recursively if path_prefix is specified | |||
| if (task.getPathPrefix().isPresent()) { | |||
| task.setFiles(GcsFileInput.listFiles(task)); | |||
| if (task.getFiles().getTaskCount() == 0) { | |||
| logger.info("No file is found. Confirm path_prefix option is correct"); | |||
There was a problem hiding this comment.
IIUC, this can happen even if path_prefix is "correct". Just "No file is found there" should be sufficient as a log message.
Suggested change
| logger.info("No file is found. Confirm path_prefix option is correct"); | |
| logger.info("No file is found in the path(s) identified by path_prefix"); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Show info in case no file is found by path_prefix