Skip to content

Add Ssl enum #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Add Ssl enum #108

wants to merge 1 commit into from

Conversation

hiroyuki-sato
Copy link
Member

Add enum Ssl for support SSL option (ex. embulk-input-mysql).

@hiroyuki-sato hiroyuki-sato mentioned this pull request May 26, 2017
Merged
@hito4t
Copy link
Contributor

hito4t commented Jun 2, 2017

Is this PR needed?
The PR #109 contains Ssl enum.

@hiroyuki-sato
Copy link
Member Author

I just want to separate this PR and #109. But I didn't know how to do it.

@hito4t
Copy link
Contributor

hito4t commented Jun 2, 2017

I think you don't need to separate #108 and #109 .
Why do you want to do?

@hiroyuki-sato
Copy link
Member Author

OK, I close this issue.
I just wanted to create PRs like the following.
I thought this way convenient for future development.

@hiroyuki-sato hiroyuki-sato deleted the share_ssl_enum branch June 2, 2017 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hiroyuki-sato @hito4t