Skip to content

Update JDBC driver version to support utf8mb4 #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Update JDBC driver version to support utf8mb4 #125

wants to merge 1 commit into from

Conversation

y-ken
Copy link
Contributor

@y-ken y-ken commented Nov 29, 2017

utf8mb4 supports emoji strings.
This patch fixes #114 issue.

@y-ken y-ken mentioned this pull request Nov 29, 2017
Merged
@y-ken
Copy link
Contributor Author

y-ken commented Nov 29, 2017

I have proposed pull request like this embulk-input-mysql.
embulk/embulk-output-jdbc#218

@hiroyuki-sato
Copy link
Member

Hello, @y-ken Thank you for this PR.

We discussed this change before. (#103)

I think this PR need discuss the following changes at the same time.

  • When the parameter useLegacyDatetimeCode change to false by default.
  • Need check effectivity two parameters noTimezoneConversionForDateType and cacheDefaultTimezone. Those parameters are introduced Connector/J 5.1.34. Maybe, It doesn't change those parameters explicitly. I asked this MySQL Forum before.

@hiroyuki-sato hiroyuki-sato mentioned this pull request Dec 25, 2017
Closed
@hito4t
Copy link
Contributor

hito4t commented Dec 25, 2017

@y-ken @hiroyuki-sato
I've merged the changes with the PR #104 .

@hito4t hito4t closed this Dec 27, 2017
@hito4t hito4t added this to the 0.9.0 milestone Dec 27, 2017
@y-ken
Copy link
Contributor Author

y-ken commented Dec 27, 2017

Thank you very much!

@y-ken y-ken deleted the patch-1 branch December 27, 2017 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
0.9.0
Development

Successfully merging this pull request may close these issues.

[MySQL] utf8mb4 support
3 participants
@y-ken @hiroyuki-sato @hito4t