Skip to content

Output JDBC driver version and MySQL Connector/J update warning #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 30, 2017
Merged

Output JDBC driver version and MySQL Connector/J update warning #182

merged 2 commits into from
Jun 30, 2017

Conversation

hiroyuki-sato
Copy link
Member

his PR the changes the following

  • Output the JDBC Driver version.
  • Add MySQL Connector/J warning before an update Connector/J.

This PR is the same embulk/embulk-input-jdbc#110

@hito4t I wrote con.showDriverVersion in the begin method.
It called from transaction and resume.
What do you think it is the proper place?

Output examples are below.

2017-06-25 10:31:32.318 +0900 [INFO] (0001:transaction): Using JDBC Driver PostgreSQL 9.4 JDBC4.1 (build 1205)

2017-06-25 10:32:53.356 +0900 [INFO] (0001:transaction): Using JDBC Driver mysql-connector-java-5.1.34 ( Revision: [email protected] )
2017-06-25 10:32:53.357 +0900 [WARN] (0001:transaction): This plugin will update MySQL Connector/J version in the near future release.
2017-06-25 10:32:53.357 +0900 [WARN] (0001:transaction): It has some incompatibility changes.
2017-06-25 10:32:53.357 +0900 [WARN] (0001:transaction): For example, the 5.1.35 introduced `noTimezoneConversionForDateType` and `cacheDefaultTimezone` options.
2017-06-25 10:32:53.357 +0900 [WARN] (0001:transaction): Please read a document and make sure configuration carefully before updating the plugin.

@hiroyuki-sato hiroyuki-sato mentioned this pull request Jun 25, 2017
Merged
@hito4t
Copy link
Contributor

hito4t commented Jun 30, 2017

Thank you!

@hito4t hito4t merged commit b10b3b5 into embulk:master Jun 30, 2017
@hiroyuki-sato
Copy link
Member Author

Thank you!

@hiroyuki-sato hiroyuki-sato deleted the jdbc_driver_version branch June 30, 2017 03:59
@hito4t hito4t added this to the 0.7.10 milestone Jul 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
0.7.10
Development

Successfully merging this pull request may close these issues.
2 participants
@hiroyuki-sato @hito4t