-
Notifications
You must be signed in to change notification settings - Fork 57
Feature: Add LLMRecommender #561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This update introduces an optional DataFrame for related data from similar optimization campaigns, enhancing the recommendation process by allowing the model to learn from past experiments. The related data is now included in the prompt construction and output formatting.
|
||
|
||
@define | ||
class ParameterDescription: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @tobiasploetz, thanks a lot for creating the PR. Haven't had a detailed look yet but only a very brief high-level discussion with @Scienfitz. So quick question upfront: To both of us, it appears that the ParameterDescription
class pretty much reinvents the wheel since it basically fully mirrors the already existing Parameter
subclasses content-wise. So question from our side: is there any reason that we don't see at the moment why you added it, other than Parameter
not having a metadata
field yet?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More context: we were already discussing some time ago the ability to provide some metadata for objects like targets, parameters and objectives (for units, descriptions, comments etc). This would probably completely avoid the need for you to here create specific objects for that. Instead you could just access a description
metadata field or so of the respective objects (empty string by default).
Question is how to proceed here then, because no work providing implementing the metadata has started yet.
…that can then be filtered with an external feasibility checker
@tobiasploetz - with #580 now being merged, what is the state here? |
I need to modify this PR to use the new metadata fields. It's in the backlog :) |
Example usage: