Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to CMake #33

Merged
merged 9 commits into from
Jan 9, 2024
Merged

Switch to CMake #33

merged 9 commits into from
Jan 9, 2024

Conversation

edoardob90
Copy link
Member

@edoardob90 edoardob90 commented Jan 8, 2024

fixes #13

Something to add to the README (maybe): set CMAKE_PREFIX_PATH if OpenBLAS library is installed in a non-standard path. For instance, when using Brew on macOS to install the library:

cmake -S . -B build -DCMAKE_PREFIX_PATH="/opt/homebrew/opt/openblas"

@edoardob90 edoardob90 requested a review from yakutovicha January 8, 2024 16:13
Copy link

codecov bot commented Jan 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b632480) 100.00% compared to head (aaf4c29) 100.00%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #33   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines           22        22           
=========================================
  Hits            22        22           
Flag Coverage Δ
python-3.10 100.00% <ø> (ø)
python-3.11 100.00% <ø> (ø)
python-3.12 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edoardob90
Copy link
Member Author

Reminder: we should also remove the Makefile(s).

@yakutovicha
Copy link
Member

Something to add to the README (maybe): set CMAKE_PREFIX_PATH if OpenBLAS library is installed in a non-standard path. For instance, when using Brew on macOS to install the library:

cmake -S . -B build -DCMAKE_PREFIX_PATH="/opt/homebrew/opt/openblas"

I put it to the wiki: https://github.com/empa-scientific-it/cleedpy/wiki/For-Developers

Copy link
Member

@yakutovicha yakutovicha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yakutovicha yakutovicha merged commit 4143225 into main Jan 9, 2024
8 checks passed
@yakutovicha yakutovicha deleted the cmake branch January 9, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve Makefile
2 participants