-
Notifications
You must be signed in to change notification settings - Fork 462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(desktop): save and restore window state #1852
Conversation
I'm considering removing the height and width fields from SettingEntity Reasons:
|
@ni00 Thank you very much for your contribution to the project! I have optimized the existing code and resolved the building error. I completely agree with your views on storing window width and height data. In version v1.x, we will no longer use the width and height from the database table. These have already been removed in version v2.x. For more details on the changes, please see: #1868 |
Thanks to all @ni00 @Red-Asuka |
PR Checklist
What is the current behavior?
Won't save and restore window position and size.
Issue Number
#1849
What is the new behavior?
Save and restore window position and size.
Does this PR introduce a breaking change?
Specific Instructions
Other information
reference: electron/electron#526