This repository was archived by the owner on Nov 1, 2021. It is now read-only.
More array splitting, handle select and phi #179
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eddyb
reviewed
Apr 9, 2017
| NewPhi->addIncoming(EV, IncomingBB); | ||
| } | ||
|
|
||
| // Reconstruct the original struct value. |
eddyb
reviewed
Apr 9, 2017
| Value *NewStruct = UndefValue::get(ATy); | ||
|
|
||
| bool NeedsAnotherPass = false; | ||
| // Create a separate select instruction for each struct field. |
eddyb
reviewed
Apr 9, 2017
| Select); | ||
| NeedsAnotherPass = NeedsAnotherPass || DoAnotherPass(NewSelect); | ||
|
|
||
| // Reconstruct the struct value. |
|
I am a bit surprised that it's not easy to handle load/store/select/phi for both structs and arrays a bit more uniformly, but I suppose C++ and LLVM don't make it easy 😞. |
|
Thanks, a bunch of places needed struct=>array renaming, fixed. And yeah, it's a little sad we can't use a template for both. But we hit things like getElementType() needing an index for structs but not for arrays, so indeed C++ and LLVM make that tricky... |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #178