Skip to content

Use JSON snapshots for all code size tests. NFC #24672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 22, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
5 changes: 3 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -61,8 +61,9 @@ jobs:
echo "Checking out ${{ github.base_ref }}"
git checkout ${{ github.base_ref }}
git rev-parse HEAD
# Hack to honor changes to rebaseline_tests.py in the current PR
git checkout - ./tools/maint/rebaseline_tests.py
# Uncomment this like to pull the rebaseline_tests.py from the
# current branch:
# git checkout - ./tools/maint/rebaseline_tests.py
./bootstrap
if ! ./tools/maint/rebaseline_tests.py --check-only; then
echo "Test expectations are out-of-date on the target branch."
Expand Down
1 change: 0 additions & 1 deletion test/browser/test_small_js_flags.js.size

This file was deleted.

41 changes: 41 additions & 0 deletions test/code_size/test_codesize_cxx_ctors1.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
{
"a.out.js": 19802,
"a.out.js.gz": 8162,
"a.out.nodebug.wasm": 129507,
"a.out.nodebug.wasm.gz": 49234,
"total": 149309,
"total_gz": 57396,
"sent": [
"__cxa_throw",
"_abort_js",
"_tzset_js",
"emscripten_resize_heap",
"environ_get",
"environ_sizes_get",
"fd_close",
"fd_read",
"fd_seek",
"fd_write"
],
"imports": [
"env.__cxa_throw",
"env._abort_js",
"env._tzset_js",
"env.emscripten_resize_heap",
"wasi_snapshot_preview1.environ_get",
"wasi_snapshot_preview1.environ_sizes_get",
"wasi_snapshot_preview1.fd_close",
"wasi_snapshot_preview1.fd_read",
"wasi_snapshot_preview1.fd_seek",
"wasi_snapshot_preview1.fd_write"
],
"exports": [
"__indirect_function_table",
"__wasm_call_ctors",
"_emscripten_stack_alloc",
"_emscripten_stack_restore",
"emscripten_stack_get_current",
"main",
"memory"
]
}
37 changes: 37 additions & 0 deletions test/code_size/test_codesize_cxx_ctors2.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
{
"a.out.js": 19780,
"a.out.js.gz": 8151,
"a.out.nodebug.wasm": 128935,
"a.out.nodebug.wasm.gz": 48881,
"total": 148715,
"total_gz": 57032,
"sent": [
"__cxa_throw",
"_abort_js",
"_tzset_js",
"emscripten_resize_heap",
"environ_get",
"environ_sizes_get",
"fd_close",
"fd_read",
"fd_seek",
"fd_write"
],
"imports": [
"env._abort_js",
"env._tzset_js",
"env.emscripten_resize_heap",
"wasi_snapshot_preview1.fd_close",
"wasi_snapshot_preview1.fd_read",
"wasi_snapshot_preview1.fd_seek",
"wasi_snapshot_preview1.fd_write"
],
"exports": [
"__indirect_function_table",
"_emscripten_stack_alloc",
"_emscripten_stack_restore",
"emscripten_stack_get_current",
"main",
"memory"
]
}
104 changes: 104 additions & 0 deletions test/code_size/test_codesize_cxx_except.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,104 @@
{
"a.out.js": 23463,
"a.out.js.gz": 9150,
"a.out.nodebug.wasm": 171285,
"a.out.nodebug.wasm.gz": 57342,
"total": 194748,
"total_gz": 66492,
"sent": [
"__cxa_begin_catch",
"__cxa_end_catch",
"__cxa_find_matching_catch_2",
"__cxa_find_matching_catch_3",
"__cxa_rethrow",
"__cxa_throw",
"__cxa_uncaught_exceptions",
"__resumeException",
"_abort_js",
"_tzset_js",
"emscripten_resize_heap",
"environ_get",
"environ_sizes_get",
"fd_close",
"fd_read",
"fd_seek",
"fd_write",
"invoke_diii",
"invoke_fiii",
"invoke_i",
"invoke_ii",
"invoke_iii",
"invoke_iiii",
"invoke_iiiii",
"invoke_iiiiii",
"invoke_iiiiiii",
"invoke_iiiiiiii",
"invoke_iiiiiiiiiii",
"invoke_iiiiiiiiiiii",
"invoke_iiiiiiiiiiiii",
"invoke_jiiii",
"invoke_v",
"invoke_vi",
"invoke_vii",
"invoke_viii",
"invoke_viiii",
"invoke_viiiiiii",
"invoke_viiiiiiiiii",
"invoke_viiiiiiiiiiiiiii"
],
"imports": [
"env.__cxa_begin_catch",
"env.__cxa_end_catch",
"env.__cxa_find_matching_catch_2",
"env.__cxa_find_matching_catch_3",
"env.__cxa_rethrow",
"env.__cxa_throw",
"env.__cxa_uncaught_exceptions",
"env.__resumeException",
"env._abort_js",
"env._tzset_js",
"env.emscripten_resize_heap",
"env.invoke_diii",
"env.invoke_fiii",
"env.invoke_i",
"env.invoke_ii",
"env.invoke_iii",
"env.invoke_iiii",
"env.invoke_iiiii",
"env.invoke_iiiiii",
"env.invoke_iiiiiii",
"env.invoke_iiiiiiii",
"env.invoke_iiiiiiiiiiii",
"env.invoke_jiiii",
"env.invoke_v",
"env.invoke_vi",
"env.invoke_vii",
"env.invoke_viii",
"env.invoke_viiii",
"env.invoke_viiiiiii",
"env.invoke_viiiiiiiiii",
"env.invoke_viiiiiiiiiiiiiii",
"wasi_snapshot_preview1.environ_get",
"wasi_snapshot_preview1.environ_sizes_get",
"wasi_snapshot_preview1.fd_close",
"wasi_snapshot_preview1.fd_read",
"wasi_snapshot_preview1.fd_seek",
"wasi_snapshot_preview1.fd_write"
],
"exports": [
"__cxa_can_catch",
"__cxa_decrement_exception_refcount",
"__cxa_free_exception",
"__cxa_get_exception_ptr",
"__cxa_increment_exception_refcount",
"__indirect_function_table",
"__wasm_call_ctors",
"_emscripten_stack_alloc",
"_emscripten_stack_restore",
"_emscripten_tempret_set",
"emscripten_stack_get_current",
"main",
"memory",
"setThrew"
]
}
38 changes: 38 additions & 0 deletions test/code_size/test_codesize_cxx_except_wasm.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
{
"a.out.js": 19691,
"a.out.js.gz": 8110,
"a.out.nodebug.wasm": 144643,
"a.out.nodebug.wasm.gz": 54892,
"total": 164334,
"total_gz": 63002,
"sent": [
"_abort_js",
"_tzset_js",
"emscripten_resize_heap",
"environ_get",
"environ_sizes_get",
"fd_close",
"fd_read",
"fd_seek",
"fd_write"
],
"imports": [
"env._abort_js",
"env._tzset_js",
"env.emscripten_resize_heap",
"wasi_snapshot_preview1.environ_get",
"wasi_snapshot_preview1.environ_sizes_get",
"wasi_snapshot_preview1.fd_close",
"wasi_snapshot_preview1.fd_read",
"wasi_snapshot_preview1.fd_seek",
"wasi_snapshot_preview1.fd_write"
],
"exports": [
"__indirect_function_table",
"__trap",
"__wasm_call_ctors",
"_emscripten_stack_alloc",
"main",
"memory"
]
}
38 changes: 38 additions & 0 deletions test/code_size/test_codesize_cxx_except_wasm_legacy.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
{
"a.out.js": 19691,
"a.out.js.gz": 8110,
"a.out.nodebug.wasm": 142232,
"a.out.nodebug.wasm.gz": 54356,
"total": 161923,
"total_gz": 62466,
"sent": [
"_abort_js",
"_tzset_js",
"emscripten_resize_heap",
"environ_get",
"environ_sizes_get",
"fd_close",
"fd_read",
"fd_seek",
"fd_write"
],
"imports": [
"env._abort_js",
"env._tzset_js",
"env.emscripten_resize_heap",
"wasi_snapshot_preview1.environ_get",
"wasi_snapshot_preview1.environ_sizes_get",
"wasi_snapshot_preview1.fd_close",
"wasi_snapshot_preview1.fd_read",
"wasi_snapshot_preview1.fd_seek",
"wasi_snapshot_preview1.fd_write"
],
"exports": [
"__indirect_function_table",
"__trap",
"__wasm_call_ctors",
"_emscripten_stack_alloc",
"main",
"memory"
]
}
42 changes: 42 additions & 0 deletions test/code_size/test_codesize_cxx_lto.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
{
"a.out.js": 19506,
"a.out.js.gz": 8014,
"a.out.nodebug.wasm": 121757,
"a.out.nodebug.wasm.gz": 48787,
"total": 141263,
"total_gz": 56801,
"sent": [
"a (emscripten_resize_heap)",
"b (_tzset_js)",
"c (_setitimer_js)",
"d (_emscripten_runtime_keepalive_clear)",
"e (_abort_js)",
"f (proc_exit)",
"g (fd_write)",
"h (fd_seek)",
"i (fd_read)",
"j (fd_close)",
"k (environ_sizes_get)",
"l (environ_get)"
],
"imports": [
"a (emscripten_resize_heap)",
"b (_tzset_js)",
"c (_setitimer_js)",
"d (_emscripten_runtime_keepalive_clear)",
"e (_abort_js)",
"f (proc_exit)",
"g (fd_write)",
"h (fd_seek)",
"i (fd_read)",
"j (fd_close)",
"k (environ_sizes_get)",
"l (environ_get)"
],
"exports": [
"m (memory)",
"n (__wasm_call_ctors)",
"o (main)",
"p (_emscripten_timeout)"
]
}
Loading