Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(sanitycheck): check vms are backed up on a regular basis #28

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

feat(sanitycheck): check vms are backed up on a regular basis #28

wants to merge 10 commits into from
+382 −44

Conversation

plaffitt
Copy link
Collaborator

No description provided.

@plaffitt plaffitt force-pushed the feat/sanity-check-vm-backup branch 12 times, most recently from 0eefe03 to 6f7f52c Compare December 20, 2024 12:05
@plaffitt plaffitt marked this pull request as ready for review December 20, 2024 12:07
lcaflc
lcaflc reviewed Dec 20, 2024
View reviewed changes
src/pvecontrol/config.py Outdated Show resolved Hide resolved
src/pvecontrol/config.py Outdated Show resolved Hide resolved
@plaffitt plaffitt changed the title feat(sanitycheck): check vms are backed up on a regular basis draft: feat(sanitycheck): check vms are backed up on a regular basis Dec 30, 2024
@plaffitt plaffitt marked this pull request as draft December 30, 2024 10:51
@plaffitt plaffitt changed the title draft: feat(sanitycheck): check vms are backed up on a regular basis feat(sanitycheck): check vms are backed up on a regular basis Dec 30, 2024
@plaffitt
Copy link
Collaborator Author

Waiting for #30 (comment) to be solved since this PR includes changes related to this subject (https://github.com/enix/pvecontrol/pull/28/files#diff-8ee363dd9a09af0683fe2b5a19d41dc89694abd901078b29a5ff881b95300d3b).

@plaffitt plaffitt force-pushed the feat/sanity-check-vm-backup branch 2 times, most recently from 7ccb544 to 530f175 Compare January 6, 2025 15:38
@plaffitt plaffitt changed the base branch from dev to main January 31, 2025 10:52
@plaffitt plaffitt force-pushed the feat/sanity-check-vm-backup branch from 530f175 to 6dfbfa0 Compare February 5, 2025 18:25
@plaffitt plaffitt marked this pull request as ready for review February 5, 2025 18:27
lcaflc
lcaflc reviewed Feb 10, 2025
View reviewed changes
src/pvecontrol/sanitycheck/tests/vm_backups.py Outdated Show resolved Hide resolved
src/pvecontrol/sanitycheck/tests/vm_backups.py Outdated Show resolved Hide resolved
src/pvecontrol/sanitycheck/tests/vm_backups.py Outdated Show resolved Hide resolved
src/pvecontrol/sanitycheck/tests/vm_backups.py Outdated Show resolved Hide resolved
@plaffitt plaffitt force-pushed the feat/sanity-check-vm-backup branch from 6dfbfa0 to 497b0fb Compare February 13, 2025 10:34
@plaffitt plaffitt force-pushed the feat/sanity-check-vm-backup branch from 497b0fb to 300e989 Compare February 13, 2025 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lcaflc lcaflc lcaflc left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@plaffitt @lcaflc