Conversation
Release: v2.18.0 prep
|
Warning Review limit reached
More reviews will be available in 16 minutes and 35 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughExtension version 2.18.0 release with monorepo dependency updates, including geo-restriction caching optimization, screening endpoint migration with error fallback inversion, Etherscan explorer URL consolidation, and consistent TypeScript tooling and hardware wallet SDK version bumps across 16 workspace packages. ChangesExtension v2.18.0 Release with Monorepo Dependency Updates
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
💼 Build Files |
gamalielhere
approved these changes
Jun 9, 2026
olgakup
approved these changes
Jun 9, 2026
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🧹 Nitpick comments (1)
packages/signers/ethereum/package.json (1)
35-50:@types/nodemismatch in@enkryptcom/signer-ethereumappears low-risk for cross-package typing
- Workspace uses
@types/node@^25.9.1in@enkryptcom/signer-ethereum(and@enkryptcom/signer-bitcoin) vs@types/node@^22.19.19in most other packages.@enkryptcom/types’sSignerInterfaceuses onlystring/unknown, andEthereumSigner/BitcoinSignerexported methods also only accept/returnstring, so Node type definitions don’t seem to leak across package boundaries.- Aligning
@types/nodeversions is still worthwhile for maintenance consistency, but this mismatch is unlikely to cause type incompatibilities by itself.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@packages/signers/ethereum/package.json` around lines 35 - 50, The package uses `@types/node`@^25.9.1 which mismatches the workspace standard `@types/node`@^22.19.19; update the devDependency entry for "`@types/node`" in packages/signers/ethereum/package.json (and mirror the same change in packages/signers/bitcoin/package.json if present) to the workspace version (^22.19.19) to align types across packages, then reinstall deps (pnpm/yarn/install) to ensure the lockfile and node resolution are consistent.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/extension/package.json`:
- Line 41: The package.json update adds `@ledgerhq/hw-transport-webusb`; inspect
all ledger modules (packages/hw-wallets/src/ledger/bitcoin/index.ts,
ethereum/index.ts, solana/index.ts, substrate/index.ts) for the symbol
webUsbTransport (and any factory functions that instantiate it) to verify where
it is created and used, update the conditional/import checks to reflect actual
usage sites (not just substrate), and run or add targeted tests/validation of
the extension hardware-wallet onboarding/connection flows for Bitcoin, Ethereum,
Solana and Substrate to ensure webUsbTransport is only invoked where supported
and onboarding still succeeds across those networks.
In `@packages/extension/src/libs/background/index.ts`:
- Around line 92-96: The geo-check is currently started but not awaited, leaving
this.#geoRestricted undefined and stale; change the flow so newWindowInit awaits
a fresh isGeoRestricted() call (or awaits the promise when undefined) before
allowing requests to proceed and update this.#geoRestricted every newWindowInit;
implement an awaited call to isGeoRestricted() (with an optional short
timeout/fallback) inside the newWindowInit path instead of the fire-and-forget
block so the gate that uses this.#geoRestricted always sees a resolved boolean.
In `@packages/signers/polkadot/package.json`:
- Line 25: The package.json for the polkadot signer incorrectly lists
"`@commitlint/cli`" under runtime "dependencies"; since there are no scripts or
code in this package that use commitlint (it’s configured at repo root), remove
"`@commitlint/cli`" from the "dependencies" object in
packages/signers/polkadot/package.json and either add it to "devDependencies" or
delete the entry entirely (if only the root uses it); update package.json
accordingly and run your package manager to refresh lockfiles.
---
Nitpick comments:
In `@packages/signers/ethereum/package.json`:
- Around line 35-50: The package uses `@types/node`@^25.9.1 which mismatches the
workspace standard `@types/node`@^22.19.19; update the devDependency entry for
"`@types/node`" in packages/signers/ethereum/package.json (and mirror the same
change in packages/signers/bitcoin/package.json if present) to the workspace
version (^22.19.19) to align types across packages, then reinstall deps
(pnpm/yarn/install) to ensure the lockfile and node resolution are consistent.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 88800eb6-9d5e-4f3d-9beb-6f8df13459a1
⛔ Files ignored due to path filters (1)
yarn.lockis excluded by!**/yarn.lock,!**/*.lock
📒 Files selected for processing (20)
package.jsonpackages/extension-bridge/package.jsonpackages/extension/package.jsonpackages/extension/src/libs/background/index.tspackages/extension/src/libs/utils/screening.tspackages/extension/src/providers/ethereum/libs/transaction/index.tspackages/extension/src/providers/ethereum/networks/eth.tspackages/hw-wallets/package.jsonpackages/keyring/package.jsonpackages/name-resolution/package.jsonpackages/request/package.jsonpackages/signers/bitcoin/package.jsonpackages/signers/ethereum/package.jsonpackages/signers/kadena/package.jsonpackages/signers/massa/package.jsonpackages/signers/polkadot/package.jsonpackages/storage/package.jsonpackages/swap/package.jsonpackages/types/package.jsonpackages/utils/package.json
💤 Files with no reviewable changes (1)
- packages/extension/src/providers/ethereum/libs/transaction/index.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
New Features
Bug Fixes
Chores