Skip to content
This repository has been archived by the owner on Dec 4, 2024. It is now read-only.

Update README.md #105

Merged
merged 2 commits into from
Jul 11, 2024
Merged

Update README.md #105

merged 2 commits into from
Jul 11, 2024

Conversation

samgun-6
Copy link
Contributor

Add missing import in code example

@seangwright
Copy link

This seems incorrect. The @milkdown-lab/plugin-fullscreen package doesn't export splitEditing or splitEditingOptionsCtx (at least as of version 1.2.3

@samgun-6
Copy link
Contributor Author

samgun-6 commented Jul 10, 2024 •
edited
Loading

This seems incorrect. The @milkdown-lab/plugin-fullscreen package doesn't export splitEditing or splitEditingOptionsCtx (at least as of version 1.2.3

Seems they should instead be imported from the package @milkdown-lab/plugin-split-editing. I added a correction.

enpitsuLin
enpitsuLin approved these changes Jul 11, 2024
View reviewed changes
Copy link
Owner

@enpitsuLin enpitsuLin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks

@enpitsuLin enpitsuLin merged commit a4812f2 into enpitsuLin:master Jul 11, 2024
1 check failed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@enpitsuLin enpitsuLin enpitsuLin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@samgun-6 @seangwright @enpitsuLin