Skip to content

Commit

Permalink
Adress issues
Browse files Browse the repository at this point in the history
  • Loading branch information
MrFlashAccount committed Dec 22, 2024
1 parent 2b29485 commit 49fb5a9
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion app/common/src/text/english.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"retry": "Retry",

"arbitraryFetchError": "An error occurred while fetching data",
"arbitraryFetchImageError": "An error occurred while fetching image",
"arbitraryFetchImageError": "An error occurred while fetching an image",

"createFolderError": "Could not create new folder",
"createProjectError": "Could not create new project",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import { useSuspenseQuery } from '@tanstack/react-query'
import type { RendererObject } from 'marked'
import { marked } from 'marked'
import { type TestIdProps } from '../AriaComponents'
import { defaultRenderer } from './defaultRenderer'
import { DEFAULT_RENDERER } from './defaultRenderer'

/** Props for a {@link MarkdownViewer}. */
export interface MarkdownViewerProps extends TestIdProps {
Expand All @@ -21,12 +21,12 @@ export interface MarkdownViewerProps extends TestIdProps {
* Parses markdown passed in as a `text` prop into HTML and displays it.
*/
export function MarkdownViewer(props: MarkdownViewerProps) {
const { text, imgUrlResolver, renderer = defaultRenderer, testId } = props
const { text, imgUrlResolver, renderer = {}, testId } = props

const { getText } = useText()
const logger = useLogger()

const markedInstance = marked.use({ renderer: Object.assign({}, defaultRenderer, renderer) })
const markedInstance = marked.use({ renderer: Object.assign({}, DEFAULT_RENDERER, renderer) })

const { data: markdownToHtml } = useSuspenseQuery({
queryKey: ['markdownToHtml', { text, imgUrlResolver, markedInstance }] as const,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import type { RendererObject } from 'marked'
import { BUTTON_STYLES, TEXT_STYLE } from '../AriaComponents'

/** The default renderer for Markdown. */
export const defaultRenderer: RendererObject = {
export const DEFAULT_RENDERER: Readonly<RendererObject> = {
/** The renderer for headings. */
heading({ depth, tokens }) {
const variant = depth === 1 ? 'h1' : 'subtitle'
Expand Down

0 comments on commit 49fb5a9

Please sign in to comment.