Skip to content

Commit

Permalink
Switch to newer MacOS GitHub runner (#11345)
Browse files Browse the repository at this point in the history
- MacOS13 (as 12 is deprecated) and 14/15 need to be large instances if we want x64.

Build seemed fine except for usual playwright fails.
  • Loading branch information
jdunkerley authored Oct 17, 2024
1 parent e7bc796 commit fb8c492
Show file tree
Hide file tree
Showing 7 changed files with 13 additions and 17 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/engine-nightly.yml
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ jobs:
enso-build-ci-gen-job-ci-check-backend-graal-vm-ce-macos-amd64:
name: Engine (GraalVM CE) (macos, amd64)
runs-on:
- macos-12
- macos-13
steps:
- if: startsWith(runner.name, 'GitHub Actions') || startsWith(runner.name, 'Hosted Agent')
name: Installing wasm-pack
Expand Down Expand Up @@ -354,7 +354,7 @@ jobs:
enso-build-ci-gen-job-jvm-tests-graal-vm-ce-macos-amd64:
name: JVM Tests (GraalVM CE) (macos, amd64)
runs-on:
- macos-12
- macos-13
steps:
- if: startsWith(runner.name, 'GitHub Actions') || startsWith(runner.name, 'Hosted Agent')
name: Installing wasm-pack
Expand Down Expand Up @@ -640,7 +640,7 @@ jobs:
enso-build-ci-gen-job-standard-library-tests-graal-vm-ce-macos-amd64:
name: Standard Library Tests (GraalVM CE) (macos, amd64)
runs-on:
- macos-12
- macos-13
steps:
- if: startsWith(runner.name, 'GitHub Actions') || startsWith(runner.name, 'Hosted Agent')
name: Installing wasm-pack
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/enso4igv.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ jobs:
target/lib/**
build_mac_intel_parser:
runs-on: macos-12
runs-on: macos-13

steps:
- uses: actions/checkout@v4
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/gui.yml
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ jobs:
enso-build-ci-gen-job-build-backend-macos-amd64:
name: Build Backend (macos, amd64)
runs-on:
- macos-12
- macos-13
steps:
- if: startsWith(runner.name, 'GitHub Actions') || startsWith(runner.name, 'Hosted Agent')
name: Installing wasm-pack
Expand Down Expand Up @@ -213,7 +213,7 @@ jobs:
enso-build-ci-gen-job-gui-build-macos-amd64:
name: GUI build (macos, amd64)
runs-on:
- macos-12
- macos-13
steps:
- if: startsWith(runner.name, 'GitHub Actions') || startsWith(runner.name, 'Hosted Agent')
name: Installing wasm-pack
Expand Down Expand Up @@ -391,7 +391,7 @@ jobs:
needs:
- enso-build-ci-gen-job-build-backend-macos-amd64
runs-on:
- macos-12
- macos-13
steps:
- if: startsWith(runner.name, 'GitHub Actions') || startsWith(runner.name, 'Hosted Agent')
name: Installing wasm-pack
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,7 @@ jobs:
needs:
- enso-build-ci-gen-draft-release-linux-amd64
runs-on:
- macos-12
- macos-13
steps:
- if: startsWith(runner.name, 'GitHub Actions') || startsWith(runner.name, 'Hosted Agent')
name: Installing wasm-pack
Expand Down Expand Up @@ -484,7 +484,7 @@ jobs:
- enso-build-ci-gen-draft-release-linux-amd64
- enso-build-ci-gen-job-upload-backend-macos-amd64
runs-on:
- macos-12
- macos-13
steps:
- if: startsWith(runner.name, 'GitHub Actions') || startsWith(runner.name, 'Hosted Agent')
name: Installing wasm-pack
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/scala-new.yml
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ jobs:
enso-build-ci-gen-job-ci-check-backend-graal-vm-ce-macos-amd64:
name: Engine (GraalVM CE) (macos, amd64)
runs-on:
- macos-12
- macos-13
steps:
- if: startsWith(runner.name, 'GitHub Actions') || startsWith(runner.name, 'Hosted Agent')
name: Installing wasm-pack
Expand Down Expand Up @@ -220,7 +220,7 @@ jobs:
enso-build-ci-gen-job-jvm-tests-graal-vm-ce-macos-amd64:
name: JVM Tests (GraalVM CE) (macos, amd64)
runs-on:
- macos-12
- macos-13
steps:
- if: startsWith(runner.name, 'GitHub Actions') || startsWith(runner.name, 'Hosted Agent')
name: Installing wasm-pack
Expand Down Expand Up @@ -390,7 +390,7 @@ jobs:
enso-build-ci-gen-job-standard-library-tests-graal-vm-ce-macos-amd64:
name: Standard Library Tests (GraalVM CE) (macos, amd64)
runs-on:
- macos-12
- macos-13
steps:
- if: startsWith(runner.name, 'GitHub Actions') || startsWith(runner.name, 'Hosted Agent')
name: Installing wasm-pack
Expand Down
3 changes: 1 addition & 2 deletions build/build/src/ci_gen/job.rs
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,6 @@ impl RunsOn for RunnerLabel {
RunnerLabel::MacOS => Some("MacOS".to_string()),
RunnerLabel::Linux => Some("Linux".to_string()),
RunnerLabel::Windows => Some("Windows".to_string()),
RunnerLabel::MacOS12 => Some("MacOS12".to_string()),
RunnerLabel::MacOS13 => Some("MacOS13".to_string()),
RunnerLabel::MacOSLatest => Some("MacOSLatest".to_string()),
RunnerLabel::LinuxLatest => Some("LinuxLatest".to_string()),
Expand Down Expand Up @@ -87,7 +86,7 @@ impl RunsOn for OS {
impl RunsOn for (OS, Arch) {
fn runs_on(&self) -> Vec<RunnerLabel> {
match self {
(OS::MacOS, Arch::X86_64) => vec![RunnerLabel::MacOS12],
(OS::MacOS, Arch::X86_64) => vec![RunnerLabel::MacOS13],
(os, Arch::X86_64) => runs_on(*os, RunnerType::SelfHosted),
(OS::MacOS, Arch::AArch64) => {
let mut ret = runs_on(OS::MacOS, RunnerType::SelfHosted);
Expand Down
3 changes: 0 additions & 3 deletions build/ci_utils/src/actions/workflow/definition.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1014,9 +1014,6 @@ pub enum RunnerLabel {
Windows,
#[serde(rename = "engine")]
Engine,
#[serde(rename = "macos-12")]
MacOS12,
/// macos-13 is the last x64 version of the GitHub-hosted macOS runner.
#[serde(rename = "macos-13")]
MacOS13,
#[serde(rename = "macos-latest")]
Expand Down

0 comments on commit fb8c492

Please sign in to comment.