Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review and add tests for Enso_File functionality #8808

Closed
7 tasks done
radeusgd opened this issue Jan 19, 2024 · 1 comment · Fixed by #8815
Closed
7 tasks done

Review and add tests for Enso_File functionality #8808

radeusgd opened this issue Jan 19, 2024 · 1 comment · Fixed by #8815
Assignees
@radeusgd
Labels
-libs Libraries: New libraries to be implemented l-cloud-integration Enso Cloud integration work

Comments

@radeusgd
Copy link
Member

radeusgd commented Jan 19, 2024 •
edited
Loading

Directories

  • List user’s root directory
  • Create a subdirectory
  • Delete a directory (including contents)
  • Add support for current_working_directory
    • use it as default instead of root

File Read / Metadata

  • tests should for now rely on a known file existing on the Cloud
    • Later we will re-structure this test to be self-contained relying on Enso_File writing
  • Ability to read a plain text file (specific format doesn’t matter just wanting to check streams).
  • Access to metadata information about a file (size, owner?, parent folder).
    • full path?
  • Review completeness of the read part of Enso_File API vs equivalent of File API.
@radeusgd radeusgd added -libs Libraries: New libraries to be implemented l-cloud-integration Enso Cloud integration work labels Jan 19, 2024
@radeusgd radeusgd self-assigned this Jan 19, 2024
@radeusgd radeusgd moved this from ❓New to 🔧 Implementation in Issues Board Jan 19, 2024
@radeusgd radeusgd mentioned this issue Jan 19, 2024
Merged
6 tasks
@enso-bot
Copy link

enso-bot bot commented Jan 22, 2024

Radosław Waśko reports a new STANDUP for the provided date (2024-01-19):

Progress: Fighting with CI to merge #8774. Adding missing methods to Enso_File, adding tests. Reviewing what works and what is missing to get up to spec. Some cleanup and tests in types project. It should be finished by 2024-01-25.

Next Day: Next day I will be working on the #8809 task. Next tasks.

@radeusgd radeusgd moved this from 🔧 Implementation to 👁️ Code review in Issues Board Jan 22, 2024
@radeusgd radeusgd linked a pull request Jan 25, 2024 that will close this issue
Adding tests and missing methods for Enso_File. #8815
Merged
6 tasks
@mergify mergify bot closed this as completed in #8815 Jan 26, 2024
mergify bot pushed a commit that referenced this issue Jan 26, 2024
@radeusgd
Adding tests and missing methods for Enso_File. (#8815)
ca4f98c 
- Closes #8808 - adds tests for various scenarios.
- Implements `size` using HEAD.
- Updates existing functions to changes in Cloud API.
- Adds stubs for `*_time` methods, `parent`, `path`.
- [x] TODO: resolve the `Enso_File.current_working_directory` from an environment variable.
- ~~TODO: recursive directory deletion?~~ left for later

# Important Notes
- Currently, the Cloud API does not offer an easy way to extract metadata for a file, in particular to get the parent folder from the file `id`.
- We should be able to get the parent, and stuff like creation/modified time.
- We need a way to resolve paths to asset ids, for `path` to work as well as `current_working_directory`.
- What is the environment variable that will be used to feed the `current_working_directory` property?
@github-project-automation github-project-automation bot moved this from 👁️ Code review to 🟢 Accepted in Issues Board Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@radeusgd radeusgd

Labels
-libs Libraries: New libraries to be implemented l-cloud-integration Enso Cloud integration work
Projects
Issues Board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adding tests and missing methods for Enso_File. enso-org/enso
1 participant
@radeusgd