Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding tests and missing methods for Enso_File. #8815

Merged
merged 16 commits into from
Jan 26, 2024

Conversation

radeusgd
Copy link
Member

@radeusgd radeusgd commented Jan 19, 2024

Pull Request Description

  • Closes Review and add tests for Enso_File functionality #8808 - adds tests for various scenarios.
  • Implements size using HEAD.
  • Updates existing functions to changes in Cloud API.
  • Adds stubs for *_time methods, parent, path.
  • TODO: resolve the Enso_File.current_working_directory from an environment variable.
  • TODO: recursive directory deletion? left for later

Important Notes

  • Currently, the Cloud API does not offer an easy way to extract metadata for a file, in particular to get the parent folder from the file id.
    • We should be able to get the parent, and stuff like creation/modified time.
  • We need a way to resolve paths to asset ids, for path to work as well as current_working_directory.
  • What is the environment variable that will be used to feed the current_working_directory property?

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

@radeusgd radeusgd added the CI: No changelog needed Do not require a changelog entry for this PR. label Jan 19, 2024
@radeusgd radeusgd self-assigned this Jan 19, 2024
@radeusgd radeusgd force-pushed the wip/radeusgd/8723-secrets-in-folders branch from b20faae to c3c0a37 Compare January 22, 2024 07:47
@radeusgd radeusgd force-pushed the wip/radeusgd/8808-enso-file-tests branch 3 times, most recently from d771310 to d8c7d94 Compare January 23, 2024 16:04
Base automatically changed from wip/radeusgd/8723-secrets-in-folders to develop January 24, 2024 10:17
@radeusgd radeusgd force-pushed the wip/radeusgd/8808-enso-file-tests branch from d8c7d94 to 6a9ca1f Compare January 24, 2024 10:20
@radeusgd radeusgd force-pushed the wip/radeusgd/8808-enso-file-tests branch from 6a9ca1f to 382ae70 Compare January 24, 2024 15:55
@radeusgd radeusgd linked an issue Jan 25, 2024 that may be closed by this pull request
7 tasks
@radeusgd radeusgd marked this pull request as ready for review January 26, 2024 13:24
@radeusgd radeusgd added the CI: Ready to merge This PR is eligible for automatic merge label Jan 26, 2024
@mergify mergify bot merged commit ca4f98c into develop Jan 26, 2024
27 of 28 checks passed
@mergify mergify bot deleted the wip/radeusgd/8808-enso-file-tests branch January 26, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review and add tests for Enso_File functionality
3 participants