Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Async Execution (project scheduling) #10827

Merged
merged 181 commits into from
Jan 22, 2025
Merged

Async Execution (project scheduling) #10827

merged 181 commits into from
Jan 22, 2025

Conversation

somebody1234
Copy link
Contributor

@somebody1234 somebody1234 commented Aug 16, 2024 •
edited
Loading

Pull Request Description

⚠️ This is currently blocked waiting for the corresponding backend functionality.

  • Frontend part of https://github.com/enso-org/cloud-v2/issues/1392
    • New modal to schedule project executions
    • New tab in asset right menu that lists project executions
    • Choose repeat interval (hourly, daily, weekly, monthly)
    • Choose parallel mode to control behavior when multiple executions are scheduled at the same time (ignore new execution if old one is not finished, cancel old execution, run both executions at the same time)
    • Select and display maximum execution time
    • "Use Current Version" button
    • Paused ("disabled") schedules

Important Notes

None

Screenshots

"New Schedule" dialog
image

List of execution schedules:
image

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.

@somebody1234
Initial backend endpoint for listing project executions
13ed6e0
@somebody1234
Add rest of backend endpoints for managing executions
9806579
@somebody1234
Initial UI for "new execution" modal
68e015e
@somebody1234
Basic display for schedules
06c0ec6
@somebody1234
Merge branch 'develop' into wip/sb/async-execution
11fb274
@somebody1234
Switch createProjectExecution to backendMutationOptions
aed5317
@somebody1234
Fixes
c5c2b7f
@somebody1234
Improve UI of "Executions" tab in Asset Panel
ce7d0bf
@somebody1234
More adjustments for Project Execution side panel
da0266d
@somebody1234
Add button to delete project executions
e9126d8
@somebody1234
More fine adjustments
48af61e
@somebody1234
More improvements to Project Executions side panel display
409ae2f
@somebody1234
Sanitize irrelevant fields from Project Execution form
3e0dc7c
@somebody1234
More fixes
c1329d2
@somebody1234
Fix default values for forms
456a56a
@somebody1234
WIP: Switch to date picker
55d3176
@somebody1234
Merge branch 'develop' into wip/sb/async-execution
3eafb1f
@somebody1234
Initial implementation of Date Picker component
16d86ad
@somebody1234
Refactor form types
f83b209
@somebody1234
Adjustments to date picker and "new schedule" form
44ffd7e
@somebody1234
Add colors to execution settings to make them easier to distinguish
1feda35
@somebody1234
Fix size of DatePicker calendar popover
0d5dec9
@somebody1234
Temporarily log backend calls
aac5196
@somebody1234 somebody1234 added CI: No changelog needed Do not require a changelog entry for this PR. x-new-feature Type: new feature request g-dashboard labels Aug 16, 2024
@somebody1234
Remove code from wrong directory
c22af89
@somebody1234
Fix DatePicker calendar not appearing
c85c588
@somebody1234
Prevent form default submit action for project executions calendar
e5b2cd4
@somebody1234
Add invalidations for project execution mutations
5387aa2
@somebody1234
Remove mocks for async execution
95abb55
@somebody1234
Fix errors
2356acf
@somebody1234
Revert "Remove mocks for async execution"
18cb1df 
This reverts commit 95abb55.
@somebody1234
Remove mode="wait" in AnimatedBackground because there are no lon…
de0d020 
…ger any layouts that are animating when the parent is also animating
@somebody1234
Hide "parallel mode" and "maximum duration" options behind feature flag
7df56c6
@somebody1234
Fix class names
5caee8d
@somebody1234
Fix canceling "new schedule" form in calendar
64d6009
@somebody1234
Fix infinite re-render loop
e55168b
@somebody1234
Reapply "Remove mocks for async execution"
4ec4b65 
This reverts commit 18cb1df.
@somebody1234
Prettier
1d00af1
@somebody1234
Fix errors
4681416
@somebody1234 somebody1234 marked this pull request as ready for review January 19, 2025 12:26
@PabloBuchu
Copy link
Contributor

PabloBuchu commented Jan 20, 2025 •
edited
Loading

  1. First occurrence input display date time but I can only accurately edit date. It does not allow my to adjust hour or minutes.
  2. Disabled (click to enable) click resulted in 404 POST to https://xw0g8j3tsb.execute-api.eu-west-1.amazonaws.com/executions/undefined
    2.1 Same with delete
    2.2 Same with sync
  3. When are the executions fetched? I saw the request only once per project.. I removed them from db and still see them in GUI
  4. Thats not much visible.. lets have a number of scheduled executions per day here
Screenshot 2025-01-20 at 15 10 27 5. New schedule in executions tab opens a dialog while the same button in calendar opens bellow... We should have this consistent and always open in dialog 6. Also when I try to submit new schedule from the calendar tab I ends with Enso being reloaded

@MrFlashAccount
Copy link
Contributor

MrFlashAccount commented Jan 21, 2025 •
edited
Loading

When are the executions fetched? I saw the request only once per project.. I removed them from db and still see them in GUI

They're cached for a couple of minutes, as any query. guess we need refetch interval here aswell?

@MrFlashAccount
Fix critical bugs
2692eba
@MrFlashAccount
Fixes
1b7e294
@MrFlashAccount
Fix devtools
9973341
@MrFlashAccount
Merge branch 'develop' into wip/sb/async-execution
157406c 
# Conflicts:
#	app/gui/src/dashboard/App.tsx
#	app/gui/src/dashboard/components/AriaComponents/Checkbox/Checkbox.tsx
#	app/gui/src/dashboard/components/AriaComponents/Inputs/ComboBox/ComboBox.tsx
#	app/gui/src/dashboard/components/AriaComponents/Inputs/DatePicker/DatePicker.tsx
#	app/gui/src/dashboard/components/AriaComponents/Inputs/Input/Input.tsx
#	app/gui/src/dashboard/components/AriaComponents/Inputs/MultiSelector/MultiSelector.tsx
#	app/gui/src/dashboard/components/AriaComponents/Inputs/OTPInput/OTPInput.tsx
#	app/gui/src/dashboard/components/AriaComponents/Inputs/Selector/Selector.tsx
#	app/gui/src/dashboard/components/AriaComponents/Radio/RadioGroup.tsx
#	app/gui/src/dashboard/components/AriaComponents/Switch/Switch.tsx
#	app/gui/src/dashboard/components/AriaComponents/Text/Text.tsx
@MrFlashAccount
Fix lint issues
a47e9d2
@MrFlashAccount MrFlashAccount added the CI: Ready to merge This PR is eligible for automatic merge label Jan 22, 2025
@mergify mergify bot merged commit 58e1b3d into develop Jan 22, 2025
40 checks passed
@mergify mergify bot deleted the wip/sb/async-execution branch January 22, 2025 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrFlashAccount MrFlashAccount MrFlashAccount approved these changes

@PabloBuchu PabloBuchu Awaiting requested review from PabloBuchu PabloBuchu is a code owner

@indiv0 indiv0 Awaiting requested review from indiv0 indiv0 is a code owner

@Frizi Frizi Awaiting requested review from Frizi Frizi is a code owner

@farmaazon farmaazon Awaiting requested review from farmaazon farmaazon is a code owner

@vitvakatu vitvakatu Awaiting requested review from vitvakatu vitvakatu is a code owner

@kazcw kazcw Awaiting requested review from kazcw kazcw is a code owner

@AdRiley AdRiley Awaiting requested review from AdRiley AdRiley is a code owner

Assignees
No one assigned
Labels
CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge g-dashboard x-new-feature Type: new feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.