Upgrade SQLite to 3.46 #10911
Merged
Upgrade SQLite to 3.46 #10911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit b7be792.
GregoryTravis
requested review from
jdunkerley,
radeusgd,
AdRiley,
marthasharkey,
4e6,
JaroslavTulach,
hubertp and
Akirathan
as code owners
jdunkerley
approved these changes
Sep 4, 2024
Akirathan
approved these changes
Sep 5, 2024
hubertp
approved these changes
Sep 6, 2024
GregoryTravis
added
the
CI: Ready to merge
jdunkerley
added
CI: Ready to merge
somebody1234
pushed a commit
that referenced
this pull request
Sep 8, 2024
Before 3.46, the SQLite parser had a limited stack, which could overflow for certain complex queries. CTE optimizations make some of our queries much smaller, but also a little bit more deeply nested, causing the parser stack to overflow. 3.46 removes this stack limitation. Closes #10910.
jdunkerley
pushed a commit
that referenced
this pull request
Sep 9, 2024
Before 3.46, the SQLite parser had a limited stack, which could overflow for certain complex queries. CTE optimizations make some of our queries much smaller, but also a little bit more deeply nested, causing the parser stack to overflow. 3.46 removes this stack limitation. Closes #10910. (cherry picked from commit 6f97e80)
jdunkerley
pushed a commit
that referenced
this pull request
Sep 10, 2024
Before 3.46, the SQLite parser had a limited stack, which could overflow for certain complex queries. CTE optimizations make some of our queries much smaller, but also a little bit more deeply nested, causing the parser stack to overflow. 3.46 removes this stack limitation. Closes #10910. (cherry picked from commit 6f97e80)
jdunkerley
pushed a commit
that referenced
this pull request
Sep 10, 2024
Before 3.46, the SQLite parser had a limited stack, which could overflow for certain complex queries. CTE optimizations make some of our queries much smaller, but also a little bit more deeply nested, causing the parser stack to overflow. 3.46 removes this stack limitation. Closes #10910. (cherry picked from commit 6f97e80)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Before 3.46, the SQLite parser had a limited stack, which could overflow for certain complex queries.
CTE optimizations make some of our queries much smaller, but also a little bit more deeply nested, causing the parser stack to overflow. 3.46 removes this stack limitation.
Closes #10910.
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.