Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand Templates #10994

Merged
merged 15 commits into from
Sep 9, 2024
Merged

Expand Templates #10994

merged 15 commits into from
Sep 9, 2024

Conversation

jdunkerley
Copy link
Member

@jdunkerley jdunkerley commented Sep 5, 2024 •
edited
Loading

Pull Request Description

  • Update all the templates to the newest versions.
  • Fix any defects in the templates.
  • Update the rust and scala code to package and download the templates.
  • Update the front end to have images for every template (with some Gemini assists).
2024-09-06_16-37-04.mp4

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.

@jdunkerley jdunkerley added the CI: No changelog needed Do not require a changelog entry for this PR. label Sep 5, 2024
@jdunkerley jdunkerley marked this pull request as ready for review September 6, 2024 15:38
kazcw
kazcw approved these changes Sep 6, 2024
View reviewed changes
Copy link
Contributor

@kazcw kazcw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving build script changes

somebody1234
somebody1234 approved these changes Sep 6, 2024
View reviewed changes
Copy link
Contributor

@somebody1234 somebody1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR ✅ for dashboard code

MrFlashAccount
MrFlashAccount approved these changes Sep 6, 2024
View reviewed changes
Copy link
Contributor

@MrFlashAccount MrFlashAccount left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please don't merge it, I'll push a few improvements tomorrow

@MrFlashAccount
Copy link
Contributor

CleanShot.2024-09-09.at.11.06.24.mp4

Did some small improvements

@MrFlashAccount MrFlashAccount added the CI: Ready to merge This PR is eligible for automatic merge label Sep 9, 2024
@mergify mergify bot merged commit a86e37b into develop Sep 9, 2024
41 of 42 checks passed
@mergify mergify bot deleted the wip/jd/templates branch September 9, 2024 10:27
jdunkerley added a commit that referenced this pull request Sep 9, 2024
@jdunkerley
Expand Templates (#10994)
97af4f3 
- Update all the templates to the newest versions.
- Fix any defects in the templates.
- Update the rust and scala code to package and download the templates.
- Update the front end to have images for every template (with some Gemini assists).

https://github.com/user-attachments/assets/59a1f845-f409-45bb-9c77-fe3a2d1262b1

(cherry picked from commit a86e37b)
jdunkerley added a commit that referenced this pull request Sep 10, 2024
@jdunkerley
Expand Templates (#10994)
095f764 
- Update all the templates to the newest versions.
- Fix any defects in the templates.
- Update the rust and scala code to package and download the templates.
- Update the front end to have images for every template (with some Gemini assists).

https://github.com/user-attachments/assets/59a1f845-f409-45bb-9c77-fe3a2d1262b1

(cherry picked from commit a86e37b)
jdunkerley added a commit that referenced this pull request Sep 10, 2024
@jdunkerley
Expand Templates (#10994)
ddbdb20 
- Update all the templates to the newest versions.
- Fix any defects in the templates.
- Update the rust and scala code to package and download the templates.
- Update the front end to have images for every template (with some Gemini assists).

https://github.com/user-attachments/assets/59a1f845-f409-45bb-9c77-fe3a2d1262b1

(cherry picked from commit a86e37b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@4e6 4e6 4e6 approved these changes

@Frizi Frizi Frizi approved these changes

@kazcw kazcw kazcw approved these changes

@AdRiley AdRiley AdRiley approved these changes

@somebody1234 somebody1234 somebody1234 approved these changes

@JaroslavTulach JaroslavTulach JaroslavTulach approved these changes

@MrFlashAccount MrFlashAccount MrFlashAccount approved these changes

@hubertp hubertp Awaiting requested review from hubertp hubertp is a code owner

@PabloBuchu PabloBuchu Awaiting requested review from PabloBuchu PabloBuchu is a code owner

@indiv0 indiv0 Awaiting requested review from indiv0 indiv0 is a code owner

@farmaazon farmaazon Awaiting requested review from farmaazon farmaazon is a code owner

@vitvakatu vitvakatu Awaiting requested review from vitvakatu vitvakatu is a code owner

Assignees
No one assigned
Labels
CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@jdunkerley @MrFlashAccount @4e6 @Frizi @kazcw @AdRiley @somebody1234 @JaroslavTulach