Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Banker's rounding type check test failure #11049

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

GregoryTravis
Copy link
Contributor

@GregoryTravis GregoryTravis commented Sep 11, 2024

Change was introduced by the recent re-implementation using a builtin.

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.

@GregoryTravis GregoryTravis added the CI: No changelog needed Do not require a changelog entry for this PR. label Sep 11, 2024
@GregoryTravis GregoryTravis added the CI: Ready to merge This PR is eligible for automatic merge label Sep 11, 2024
@jdunkerley jdunkerley merged commit f409cb8 into develop Sep 11, 2024
32 of 36 checks passed
@jdunkerley jdunkerley deleted the wip/gmt/11048-sf-br-fail branch September 11, 2024 15:34
jdunkerley pushed a commit that referenced this pull request Sep 11, 2024
Repairs a test not run in CI

(cherry picked from commit f409cb8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants