Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cloud tests by using correct config from the repo #11223

Merged
merged 6 commits into from
Oct 2, 2024

Conversation

radeusgd
Copy link
Member

@radeusgd radeusgd commented Oct 1, 2024

Pull Request Description

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.

@radeusgd radeusgd added the CI: No changelog needed Do not require a changelog entry for this PR. label Oct 1, 2024
@radeusgd radeusgd self-assigned this Oct 1, 2024
@radeusgd
Copy link
Member Author

radeusgd commented Oct 1, 2024

Unfortunately the cloud workflow is still failing:

 INFO ide_ci::program::command: bash ℹ️ [FAILED] IO operations on Enso Cloud files: [0/1, 6129ms]
 INFO ide_ci::program::command: bash ℹ️ 
 INFO ide_ci::program::command: bash ℹ️     - [FAILED] writing Excel [6129ms]
 INFO ide_ci::program::command: bash ℹ️         Reason: An unexpected dataflow error ((Unexpected_Service_Error Post https://7aqkn3tnbc.execute-api.eu-west-1.amazonaws.com/files?parent_directory_id=directory-2lZ0142T7ghtDV0IXD4QdJYnkDt&file_name=write-test-2024-10-01_105451.306015257Etc.UTC.xlsx 500 Internal Server Error '{"message":"Internal Server Error"}')) has been matched (at /home/runner/work/enso/enso/test/Table_Tests/src/IO/Cloud_Spec.enso:25:13-38).
 INFO ide_ci::program::command: bash ℹ️         at <enso> case_branch(/home/runner/work/enso/enso/built-distribution/enso-engine-2024.5.1-dev-linux-amd64/enso-2024.5.1-dev/lib/Standard/Base/2024.5.1-dev/src/Enso_Cloud/Internal/Utils.enso:113:36-123)

But this PR fixed the setup phase - now the tests are ran correctly, they are just failing (as they would locally) due to some libs-cloud integration mishap. I will merge this PR and investigate this problem separately - as it may require action on cloud side and not necessarily an engine repo PR.

@radeusgd radeusgd added the CI: Ready to merge This PR is eligible for automatic merge label Oct 1, 2024
@radeusgd radeusgd removed the CI: Ready to merge This PR is eligible for automatic merge label Oct 1, 2024
@radeusgd radeusgd added the CI: Ready to merge This PR is eligible for automatic merge label Oct 2, 2024
@mergify mergify bot merged commit a23b669 into develop Oct 2, 2024
38 of 39 checks passed
@mergify mergify bot deleted the wip/radeusgd/fix-cloud-tests-2 branch October 2, 2024 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants