Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable audit logs for Snowflake backend #11306

Merged
merged 19 commits into from
Oct 14, 2024

Conversation

radeusgd
Copy link
Member

@radeusgd radeusgd commented Oct 11, 2024

Pull Request Description

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.

Copy link
Contributor

@somebody1234 somebody1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving new datalink schema tests

@radeusgd
Copy link
Member Author

radeusgd commented Oct 11, 2024

Our Snowflake tests have been failing for a while.

Not related to this PR, but I'll see if I can make them green.

Running tests on this branch:

@radeusgd radeusgd added the CI: No changelog needed Do not require a changelog entry for this PR. label Oct 11, 2024
@radeusgd radeusgd force-pushed the wip/radeusgd/11292-audit-logs-for-snowflake branch from e8a2f42 to 7dd4df1 Compare October 14, 2024 11:32
@radeusgd radeusgd added the CI: Ready to merge This PR is eligible for automatic merge label Oct 14, 2024
@mergify mergify bot merged commit 244effd into develop Oct 14, 2024
43 of 44 checks passed
@mergify mergify bot deleted the wip/radeusgd/11292-audit-logs-for-snowflake branch October 14, 2024 14:30
Copy link
Member

@AdRiley AdRiley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the coalesce fix :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
5 participants