Fix invocation of single benchmarks in std-benchmarks
#11321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Akirathan
added
the
CI: No changelog needed
Akirathan
requested review from
4e6,
JaroslavTulach and
hubertp
as code owners
4 tasks
This reverts commit c1d43b3.
hubertp
approved these changes
Oct 14, 2024
hubertp
added a commit
that referenced
this pull request
Oct 14, 2024
* Ensure wrapper projects are listed in aggregates Previously, doing clean to deal with weird modularization failures would have no effect. * And updated formatting * More projects As cherry-picked from #11321
Akirathan
added
CI: Keep up to date
Akirathan
removed
the
CI: Keep up to date
| @@ -3967,7 +3967,8 @@ lazy val `std-benchmarks` = (project in file("std-bits/benchmarks")) | |||
| Map( | |||
| runtimeModName -> Seq( | |||
| "ALL-UNNAMED", | |||
| (`benchmarks-common` / javaModuleName).value | |||
| (`benchmarks-common` / javaModuleName).value, | |||
| (`bench-processor` / javaModuleName).value | |||
There was a problem hiding this comment.
This may be handy in #10714 - I also had problems with access restrictions in the PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
std-benchmarks/benchOnly Map_Error_Benchmark_Vector_ignore.Map_Id_All_Errors(or any other benchmark) is failing withThis PR fixes this failure by adding
--add-reads org.enso.runtime=org.enso.bench.processorto the cmd line options forstd-benchmarks/Compile/javaOptions.Pull Request Description
Important Notes
std-benchmarks/bench, which is invoked on the CI, is not affected. It still works as expected.ensoaggregate in c1d43b3Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.